update to latest libimage #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
force-pushed
the
libimage-updates
branch
10 times, most recently
from
d6164a4 to
e003db1
Compare
Update Buildah to the latest libimage. Migrating Podman over to libimage entailed a number of fixes and changes to libimage which we need to account for in Buildah. Most notably: * `(*Runtime).LookupImage()` now returns `storage.ErrImageUnknown` instead of `nil` in case no matching image is found. * `(*Runtime).LookupImage()` now does quite a bit more work finding a local image and will also look at the repotags (or digests) of all local images if needed. * The signature of `(*Runtime).RemoveImages()` was changed and now returns a slice of reports and errors. The reports aggregate the data of a removed image which allows the function to be used by `podman image prune` which is also interested in the size of the removed data. The slice of errors is also needed in Podman which needs to have a closer look at _all_ rmi errors in order to determine the appropriate exit code (Docker compat). * `libimage/types` has been removed. Pull policies have been merged into already existing logic in `pkg/config`. Please refer to containers/podman/pull/10147 for a more detailed changelog. [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
libimage-updates
branch
from
e003db1 to
a23a49b
Compare
|
@rhatdan, ready 🏁 |
|
@giuseppe PTAL |
|
lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Buildah to the latest libimage. Migrating Podman over to
libimage entailed a number of fixes and changes to libimage which
we need to account for in Buildah.
Most notably:
(*Runtime).LookupImage()now returnsstorage.ErrImageUnknowninstead of
nilin case no matching image is found.(*Runtime).LookupImage()now does quite a bit more work findinga local image and will also look at the repotags (or digests) of
all local images if needed.
The signature of
(*Runtime).RemoveImages()was changed and nowreturns a slice of reports and errors. The reports aggregate the
data of a removed image which allows the function to be used by
podman image prunewhich is also interested in the size of theremoved data. The slice of errors is also needed in Podman which
needs to have a closer look at all rmi errors in order to determine
the appropriate exit code (Docker compat).
libimage/typeshas been removed. Pull policies have been mergedinto already existing logic in
pkg/config.Please refer to containers/podman/pull/10147 for a more detailed
changelog.
Signed-off-by: Valentin Rothberg [email protected]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?