Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert patch to allow copying of empty dirs. #3002

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 12, 2021

Revert patch to allow COPY/ADD of empty dirs.

This Patch breaks conformance with Docker.

Signed-off-by: Daniel J Walsh [email protected]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This Patch breaks conformance with Docker.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan changed the title Empty subdirs can be added to containers, fix .dockerignore test Revert patch to allow copying of empty dirs. Feb 12, 2021
@TomSweeneyRedHat
Copy link
Member

I'm not sure quite sure how the original got merged, but this is fine to pull it back for now. I still question whether or not the behavior this is reverting to is correct or not, but need to dive more deeply with some Docker testing this weekend. Regardless, this was reported against #2964 which will have to be adjusted. This change for now
LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6421c84 into containers:master Feb 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants