Fix build arg check

[umohnani8]

Signed-off-by: Urvashi Mohnani [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix the check on build args to be the length of the map
and not whether the map is nil. The nil check was causing
the cache layer to not be used as it would give a false
result.

How to verify it

Which issue(s) this PR fixes:

Fixes #2966

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[umohnani8]

Cache is being used now

➜  buildah git:(arg-cache) time ./bin/buildah bud --layers -t test . 
STEP 1: FROM ubi8
Resolved "ubi8" as an alias (/home/umohnani/.config/containers/short-name-aliases.conf)
Getting image source signatures
Copying blob cca21acb641a done  
Copying blob d9e72d058dc5 done  
Copying config 3269c37eae done  
Writing manifest to image destination
Storing signatures
STEP 2: RUN sleep 3
STEP 3: COMMIT test
--> 992958b6748
992958b6748aca166baafb4124b9df269a8ba3216f310edf14e854e1e8d10eae
./bin/buildah bud --layers -t test .  7.79s user 1.93s system 72% cpu 13.387 total
➜  buildah git:(arg-cache) time ./bin/buildah bud --layers -t test1 .
STEP 1: FROM ubi8
STEP 2: RUN sleep 3
--> Using cache 992958b6748aca166baafb4124b9df269a8ba3216f310edf14e854e1e8d10eae
STEP 3: COMMIT test1
--> 992958b6748
992958b6748aca166baafb4124b9df269a8ba3216f310edf14e854e1e8d10eae
./bin/buildah bud --layers -t test1 .  0.15s user 0.10s system 26% cpu 0.957 total

[umohnani8]

@rhatdan @nalind PTAL

[terceiro]

confirming that this patchfixes it for me. Thanks!

[nalind]

LGTM

[rhatdan]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhatdan, umohnani8
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[umohnani8]

@rhatdan the docker build conformance failures look like the file permission issue you were talking about today, how do we plan on handling this?

[rhatdan]

I am going to ignore them for now. And force merge.

[TomSweeneyRedHat]

This looks like it should be cherry picked into release-1.19 too.