[1.19] buildah manifest add localimage should work #2957
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vrothberg
changed the title
|
@nalind @giuseppe @QiWang19 @TomSweeneyRedHat PTAL This PR is not able to be merged upstream because of unrelated gzip error. |
|
Until a PR gets merged onto the master branch, |
|
The problem is the Docker 2020 is going to block anything getting merged until we figure out which way we want to on it. |
|
Since this is now merged in the main branch, I am merging it here. |
|
New changes are detected. LGTM label has been removed. |
Currently if you attempt to build create a manifest and add a local image, the command blows up. The current code always looks for a remote image. This PR fixes the code to use the local image if it exists. Signed-off-by: Daniel J Walsh <[email protected]>
Buildah bud --manifest XYZ was not working. The manifest was never created. This PR Finishes the plumbing and allows users to create a manifest while building an image in one single command. Signed-off-by: Daniel J Walsh <[email protected]>
|
New changes are detected. LGTM label has been removed. |
Currently if you attempt to build create a manifest
and add a local image, the command blows up.
The current code always looks for a remote image.
This PR fixes the code to use the local image if it
exists.
Signed-off-by: Daniel J Walsh [email protected]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?