Rebuild layer if a change in ARG is detected #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/bug
|
All kinds of test unhappiness @umohnani8 |
umohnani8
force-pushed
the
arg-cache
branch
2 times, most recently
from
4a07a77 to
d72fc30
Compare
|
LGTM |
|
@containers/podman-maintainers PTAL |
|
LGTM |
Check whether the ARG in the containerfile is changed by either the --build-arg flag or local environment and use the cached layer or rebuild the layer accordingly. Add tests for this use case as well. Signed-off-by: Urvashi Mohnani <[email protected]>
|
LGTM |
|
/lgtm |
|
We should backport to 1.19 right? |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: rhatdan, TomSweeneyRedHat, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Urvashi Mohnani [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Check whether the ARG in the containerfile is changed by
either the --build-arg flag or local environment and use
the cached layer or rebuild the layer accordingly.
Add tests for this use case as well.
How to verify it
Which issue(s) this PR fixes:
Fixes #2848
Fixes #2837
Special notes for your reviewer:
Does this PR introduce a user-facing change?