Pick default OCI Runtime from containers.conf #2929
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently we have a weird situation where the user sets the default runtime in his containers.conf for podman but Buildah is still falling back to use runc because it was hard coded as the default for Buildah. I would like to remove this default, but that would theoretically break the API promise of Buildah. This should fix containers/podman#8893 Signed-off-by: Daniel J Walsh <[email protected]>
|
@containers/podman-maintainers PTAL |
buildah.go
Outdated
| @@ -28,7 +28,7 @@ const ( | |||
| Package = "buildah" | |||
| // Version for the Package. Bump version in contrib/rpm/buildah.spec | |||
| // too. | |||
| Version = "1.19.2" | |||
| Version = "1.19.3" | |||
There was a problem hiding this comment.
you need to bump the contrib/rpm/buildah.spec too, and it would be good to update changelog.txt and CHANGELOG.md while you're at it.
There was a problem hiding this comment.
Ok I jumped the gun on this release, since there is at least one more thing we want to back port. Removing the release and only adding the cherry-pick
|
Tests are unhappy, I think due to the missing verison in the spec. Beyond that, I really much prefer having the Buildah version bump in their own PR, then any cherry picks in a separate. That way you can more easily find the cherrypick PR in GitHub's PR list. |
rhatdan
added
the
todo-backport-to-1.19
|
LGTM |
Cherry-pick "Pick default OCI Runtime from containers.conf"