Use build-arg ENV val from local environment if set #2928
Conversation
openshift-ci-robot
added
the
kind/bug
|
@umohnani8 needs a rebase already, that was quick.... |
umohnani8
force-pushed
the
env
branch
2 times, most recently
from
e20cdfd to
173881f
Compare
If a user sets the ENV to be used with the build-arg flag in the local environment by exporting it, look it up and use the value set there for that ENV. Add tests to cover this use case as well. Signed-off-by: Urvashi Mohnani <[email protected]>
|
LGTM |
|
/lgtm |
|
@cevich any idea why the cirrus-ci test is not running? |
|
@rhatdan @TomSweeneyRedHat do we need to wait for cirrus-ci? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@umohnani8 Please cherry-pick this into release-1.19 |
rhatdan
added
the
todo-backport-to-1.19
Must have been some transient problem. I heard about it happening in other Buildah PRs also. Anyway, I'm glad it sorted itself out given time. |
Signed-off-by: Urvashi Mohnani [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
If a user sets the ENV to be used with the build-arg flag in
the local environment by exporting it, look it up and use the
value set there for that ENV.
Add tests to cover this use case as well.
How to verify it
Which issue(s) this PR fixes:
Fixes #2888
Special notes for your reviewer:
Does this PR introduce a user-facing change?