Cherry pick localhost fix and update CI configuration for release-1.1… #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9 branch Cherry pick @vrothberg's "use local image name for pull policy checks" containers#2908 and update the cirrus and git validations so the test will run on this new(ish) branch. From @vrothberg: Some pull policies require to first look up a local image and compare that to the remote counter part. When looking up the remote image, we need to make sure to use the name of the local image, if it exists. This fixes a bug where a short name resolved to an image with the "localhost/" prefix. This prefix is only used for local image look ups via shortnames.ResolveLocally. Hence, when looking up the remote counter part, we must preserve this prefix. Fixes: containers#2904 Signed-off-by: TomSweeneyRedHat <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…9 branch
Cherry pick @vrothberg's "use local image name for pull policy checks" #2908
and update the cirrus and git validations so the test will run on this new(ish)
branch. From @vrothberg:
Some pull policies require to first look up a local image and compare
that to the remote counter part. When looking up the remote image, we
need to make sure to use the name of the local image, if it exists.
This fixes a bug where a short name resolved to an image with the
"localhost/" prefix. This prefix is only used for local image look ups
via shortnames.ResolveLocally. Hence, when looking up the remote
counter part, we must preserve this prefix.
Fixes: #2904
Signed-off-by: TomSweeneyRedHat [email protected]