Buildah inspect should be able to inspect manifests #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
added
the
todo-backport-to-1.19
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
force-pushed
the
inspect
branch
2 times, most recently
from
1461095 to
9d8345e
Compare
docs/buildah-inspect.md
Outdated
| Prints the low-level information on Buildah object(s) (e.g. container, images) identified by name or ID. By default, this will render all results in a | ||
| JSON array. If the container and image have the same name, this will return container JSON for unspecified type. If a format is specified, | ||
| Prints the low-level information on Buildah object(s) (e.g. container, images, manifests) identified by name or ID. By default, this will render all results in a | ||
| JSON array. If the container and image or manifest have the same name, this will return container JSON for unspecified type. If a format is specified, |
There was a problem hiding this comment.
Suggested change
| JSON array. If the container and image or manifest have the same name, this will return container JSON for unspecified type. If a format is specified, | |
| JSON array. If the container, image, or manifest have the same name, this will return container JSON for an unspecified type. If a format is specified, |
There was a problem hiding this comment.
"manifest list", or "list", please, plural if need be.
|
gce failed. One small suggestion. |
When you create a manifest or pull a manifest, it shows up inside of the buildah images list. When you go to inspect it the inspect code blows up with a cryptic error message. This patch fixes this problem and just uses the buildah manifest inspect code. Signed-off-by: Daniel J Walsh <[email protected]>
nalind
removed
the
todo-backport-to-1.19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a manifest or pull a manifest, it shows up
inside of the buildah images list. When you go to inspect it
the inspect code blows up with a cryptic error message.
This patch fixes this problem and just uses the buildah manifest inspect
code.
Signed-off-by: Daniel J Walsh [email protected]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?