pkg, cli: rootless uses correct isolation #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
when running as rootless, make sure the cli default isolation is set to "rootless" instead of "oci". Closes: containers#2750 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
rootless-isolation-default
branch
from
370a860 to
6eb5801
Compare
|
LGTM |
|
The failures are not caused by this PR Forcing merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running as rootless, make sure the cli default isolation is set
to "rootless" instead of "oci".
Closes: #2750
Signed-off-by: Giuseppe Scrivano [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
use "rootless" isolation by default when running rootless
How to verify it
follow the steps in #2750
Which issue(s) this PR fixes:
#2750
Special notes for your reviewer:
Does this PR introduce a user-facing change?