Allow users to specify stdin into containers #2847
Conversation
|
I know someone asked me for this, but I can not find the reference to it. |
|
|
Yes. |
rhatdan
force-pushed
the
stdin
branch
4 times, most recently
from
6a91c1a to
97ecce1
Compare
|
@containers/podman-maintainers PTAL |
|
Fixes: #2863 |
|
@nalind @TomSweeneyRedHat @vrothberg @giuseppe @QiWang19 @umohnani8 PTAL |
| RUN read -t 1 x | ||
| _EOF | ||
|
|
||
| run_buildah 1 bud -t testbud --signature-policy ${TESTSDIR}/policy.json ${mytmpdir} <<< input |
There was a problem hiding this comment.
There's a common pattern in buildah tests that I find odd: just test one little thing at a time. Given the substantial setup costs for each test, doesn't it make sense to occasionally bundle tests together? Like, you could combine with with --stdin: it's the same Containerfile, same setup, just a one-word difference in the command. You could first run the error one (perhaps adding expect_output --substring 'error building at STEP "RUN read -t 1 x":'), then run the one with --stdin.
I realize there are pedantic voices who will say "write microtests so that every molecular component can be individually checked!!1!". Those voices are often silent when we need to deal with CI timeout errors or simply the development hassle of waiting hours and hours for CI runs. I am rabidly in favor of multipurpose tests: they are, most of the time, Good Enough.
There was a problem hiding this comment.
No problem. I am just happy that I added some tests for it. I will consolidate.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some commands within a Containerfile, might need input from users. For example confirmation commands from Apt. Adding a --stdin flag will allows users to interact with containers while running inside of buildah bud. Signed-off-by: Daniel J Walsh <[email protected]>
nalind
added
todo-backport-to-1.16
nalind
removed
the
todo-backport-to-1.18
Some commands within a Containerfile, might need input from users.
For example confirmation commands from Apt.
Adding a --stdin flag will allows users to interact with containers
while running inside of buildah bud.
Signed-off-by: Daniel J Walsh [email protected]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?