Not use local image create/add manifest #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid first checking the image from local storage for `manifest create` and `manifest add` since the local image does not include other entries of the list from the registry. `--all` flag of `manifest create` and `manifest add` can not add all of the lists as expected. So first attempt to get manifest from the registry and if not successful, fall back to use local images. Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
add-local-manifest
branch
from
4012d16 to
b3a1c89
Compare
|
@QiWang19 does this address an issue or BZ? If so, please add a pointer to the description. |
This does not point to an issue. Just found this may cause problems when I debug other manifest issues. |
|
Changes LGTM, but definitely want a head nod from @nalind. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid first checking the image from local storage for
manifest createandmanifest addsince the local image does not include other entries of the list from the registry.
--allflag ofmanifest createandmanifest addcan not add all of the lists as expected.So first attempt to get manifest from the registry and if not successful, fall back to use local images.
Signed-off-by: Qi Wang [email protected]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?