imagebuildah: disable pseudo-terminals for RUN #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Always handle RUN instructions with no pseudo terminal, which matches what I see with docker build 19.03. Interactive 'buildah run' will still have the same default behavior. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
bud-no-terminal
branch
from
cccaa6d to
e863665
Compare
nalind
added
todo-backport-to-1.16
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
nalind
removed
the
todo-backport-to-1.18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Always handle RUN instructions with no pseudo terminal, which matches what I see with docker build 19.03. Interactive
buildah runwill still have the same default behavior.How to verify it
Tests should continue to pass, and the issue described in containers/podman#8342 should no longer occur.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?