Handle COPY --from when an argument is used #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
approved these changes
Aug 8, 2020
tests/bud.bats
Outdated
| _prefetch debian | ||
|
|
||
| run_buildah bud --build-arg base=alpine --build-arg toolchainname=busybox --build-arg destinationpath=/tmp --pull=false --signature-policy ${TESTSDIR}/policy.json -f ${TESTSDIR}/bud/from-with-arg/Containerfile . | ||
| [ "$status" -eq 0 ] |
There was a problem hiding this comment.
Done, IDK how I managed to mess that up so badly without seeing it.
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/from_args
branch
from
aedcf13 to
49dfe84
Compare
|
LGTM |
edsantiago
reviewed
Aug 10, 2020
tests/bud.bats
Outdated
| _prefetch debian | ||
|
|
||
| run_buildah bud --build-arg base=alpine --build-arg toolchainname=busybox --build-arg destinationpath=/tmp --pull=false --signature-policy ${TESTSDIR}/policy.json -f ${TESTSDIR}/bud/from-with-arg/Containerfile . | ||
| [ "$status" -eq 0 ] |
There was a problem hiding this comment.
Not necessary: run_buildah already does status checking
There was a problem hiding this comment.
keep forgetting that, thanks for the nudge, removed/fixed.
When an argument was passed into "COPY --from" command in
a Containerfile like
COPY --from=${toolchainname}
The argument was never resolved to the value that it had been
set to.
Addresses: containers#2496
It may also address containers#2404 but I've not yet tested.
Signed-off-by: TomSweeneyRedHat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/from_args
branch
from
49dfe84 to
44614d9
Compare
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an argument was passed into "COPY --from" command in
a Containerfile like
COPY --from=${toolchainname}
The argument was never resolved to the value that it had been
set to.
Addresses: #2496
It may also address #2404 but I've not yet tested.
Signed-off-by: TomSweeneyRedHat [email protected]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?