Enable --device directory as src device #1937
Conversation
|
We should have some kind of change to the man page(s) too. |
| _, err = DeviceFromPath("/dev/pts") | ||
| assert.Error(t, err) | ||
| assert.NoError(t, err) |
There was a problem hiding this comment.
Should add another test for a file
_, err = DeviceFromPath("/etc/passwd")
assert.Error(t, err)
|
📌 Commit 4db2a49 has been approved by |
Enables --device accepte directory path as source device. Add the devices under the source directory to the destination directory. complete card test criteria: https://jira.coreos.com/browse/RUN-497 related podman issue: containers/podman#2380 Signed-off-by: Qi Wang <[email protected]> Closes: #1937 Approved by: rhatdan
|
💔 Test failed - status-travis |
|
@rh-atomic-bot retry |
Enables --device accepte directory path as source device. Add the devices under the source directory to the destination directory. complete card test criteria: https://jira.coreos.com/browse/RUN-497 related podman issue: containers/podman#2380 Signed-off-by: Qi Wang <[email protected]> Closes: #1937 Approved by: rhatdan
|
💔 Test failed - status-travis |
QiWang19
force-pushed
the
dir_device
branch
2 times, most recently
from
e51ea79 to
ab3e596
Compare
|
does this error message mean some other tool does not support adding a directory of devices? |
|
@TomSweeneyRedHat Can I add another Dockerfile under tests/bud/device/? I want to try to see if |
QiWang19
force-pushed
the
dir_device
branch
2 times, most recently
from
83e6880 to
31ba7bd
Compare
Enables --device accepte directory path as source device. Add the devices under the source directory to the destination directory. complete card test criteria: https://jira.coreos.com/browse/RUN-497 related podman issue: containers/podman#2380 Signed-off-by: Qi Wang <[email protected]>
|
@TomSweeneyRedHat tests are green now. Can we get this in |
|
📌 Commit 6f6f32b has been approved by |
|
⚡ Test exempted: pull fully rebased and already tested. |
|
I'm jumping in after the barn door shut, but LGTM and nice job @QiWang19 |
Enables --device accepte directory path as source device. Add the devices under the source directory to the destination directory. complete card test criteria: https://jira.coreos.com/browse/RUN-497 related podman issue: containers/podman#2380 Signed-off-by: Qi Wang <[email protected]> Closes: containers#1937 Approved by: rhatdan
Enables --device accepte directory path as source device. Add the devices under the source directory to the destination directory.
complete card test criteria: https://jira.coreos.com/browse/RUN-497
related podman issue: containers/podman#2380
Signed-off-by: Qi Wang [email protected]