Add completions for Manifest commands #1910
Conversation
|
LGTM |
TomSweeneyRedHat
changed the title
|
I've removed the "Do Not Merge" label as #1902 has now merged. This should be gtg now and still has happy green test buttons. |
|
Don't you need to add manifest as a command to _buildah()? |
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/manifestbash
branch
from
0a31e6e to
bc6f561
Compare
|
@rhatdan PTAL |
|
LGTM |
|
LGTM |
| -*) | ||
| COMPREPLY=($(compgen -W "$boolean_options $options_with_args" -- "$cur")) | ||
| ;; | ||
| esac |
There was a problem hiding this comment.
This single-item case (?) is repeated four or five times, could it be made into a function or simplified some other way?
There was a problem hiding this comment.
Maybe it could be improved, but we've it all over the place in this file and I'm just staying between the lines....
contrib/completions/bash/buildah
Outdated
| create | ||
| inspect | ||
| push | ||
| remove |
There was a problem hiding this comment.
Trailing whitespace - I'm curious why the commit hooks didn't catch this?
|
This all gives me the sense of wandering into cargo-cult territory: the NOP-y declaration of (Not intended as a slight on your work -- this completion stuff is HARD). |
This adds the completions for the manifest commands found in containers#1902. This should not be merged until that is merged, or perhaps this should be cherry-picked into it. Signed-off-by: TomSweeneyRedHat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/manifestbash
branch
from
bc6f561 to
9843320
Compare
|
Perhaps we get an intern next summer to concentrate on improving command completions, Make them work under @edsantiago :^) |
|
📌 Commit 9843320 has been approved by |
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-papr, status-travis |
This adds the completions for the manifest commands found in containers#1902. This should not be merged until that is merged, or perhaps this should be cherry-picked into it. Signed-off-by: TomSweeneyRedHat <[email protected]> Closes: containers#1910 Approved by: rhatdan
This adds the completions for the manifest commands
found in #1902. This should not be merged until that
is merged, or perhaps this should be cherry-picked
into it.
Signed-off-by: TomSweeneyRedHat [email protected]