WIP - test copy-detection #1484
Conversation
|
We hit time outs again due to the |
vrothberg
force-pushed
the
image-commit
branch
6 times, most recently
from
e4b6dfe to
c08a58d
Compare
|
@vrothberg Can we update and merge this now? |
Not yet. The integration tests seem to have a hiccup and we need to merge the PR at c/image first. |
vrothberg
force-pushed
the
image-commit
branch
2 times, most recently
from
6292b23 to
3b92aa9
Compare
|
☔ The latest upstream changes (presumably 7ae362b) made this pull request unmergeable. Please resolve the merge conflicts. |
|
We have an up2date containers/image in buildah, should we close this PR? |
|
@rhatdan, this PR is for testing the copy-detection PR for containers/image. I renamed this one here to avoid confusion. |
|
Thanks @vrothberg |
vrothberg
force-pushed
the
image-commit
branch
2 times, most recently
from
4e277a8 to
0e82b29
Compare
|
☔ The latest upstream changes (presumably c0633e3) made this pull request unmergeable. Please resolve the merge conflicts. |
vrothberg
force-pushed
the
image-commit
branch
3 times, most recently
from
218039d to
2014056
Compare
Signed-off-by: Valentin Rothberg <[email protected]>
|
@vrothberg Any movement on this? |
containers/image#611 needs to be reviewed, which is time-consuming. FWIW the CI of Skopeo, Buildah and Podman are happy with the changes. The recursive-lock semantics are now in storage, so we only need to iron out the bits in c/image. |
|
☔ The latest upstream changes (presumably 4ae0a69) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing as the c/image PR has stalled. |
ImageDestination.{PutBlob,TryReusingBlob} are extended to receive the
index of the layer in the corresponding image. Some transports,
containers storage in particular, require the layers to be comitted in
sequence. The new sequencing allows containers storage to commit the
layers in PutBlob.
Signed-off-by: Valentin Rothberg [email protected]