Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli.BudFlags: add --platform nop #1230

Closed
wants to merge 2 commits into from
Closed

cli.BudFlags: add --platform nop #1230

wants to merge 2 commits into from

Conversation

vrothberg
Copy link
Member

Add the --platform option for Moby/Docker CLI-compat reasons. This
option allows to control which platform (i.e., Windows or Linux) the
image will be build on and for. Make this a nop as Buildah supports
only Linux.

Fixes: #629
Signed-off-by: Valentin Rothberg [email protected]

@vrothberg
Copy link
Member Author

@rhatdan @TomSweeneyRedHat PTAL

This option exists as well for run, pull and import. Shall we make it a nop for those as well? We had to touch Podman as well.

@TomSweeneyRedHat
Copy link
Member

hmm, tests seem to think you didn't sign it.

@TomSweeneyRedHat
Copy link
Member

bot, retest this please.

TomSweeneyRedHat
TomSweeneyRedHat reviewed Dec 8, 2018
View reviewed changes
pkg/cli/common.go Outdated Show resolved Hide resolved
TomSweeneyRedHat
TomSweeneyRedHat reviewed Dec 8, 2018
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need bash completions and man page updates too.

@vrothberg
Copy link
Member Author

hmm, tests seem to think you didn't sign it.

It's actually some old commits (2017) that are causing the hiccup:

c116133 - FAIL - does not have a valid DCO
 bf40000 - FAIL - does not have a valid DCO
 b9a1426 - FAIL - does not have a valid DCO
 c72d2db - FAIL - does not have a valid DCO
 d008132 - FAIL - does not have a valid DCO
 3b51b10 - FAIL - does not have a valid DCO
 121973d - FAIL - does not have a valid DCO
 d788032 - FAIL - does not have a valid DCO
 df71b8f - FAIL - does not have a valid DCO
 b8214c4 - FAIL - does not have a valid DCO
 e63629b - FAIL - does not have a valid DCO
 b58b778 - FAIL - does not have a valid DCO
 56f61d9 - FAIL - does not have a valid DCO
 547afe5 - FAIL - does not have a valid DCO
 e62d7d9 - FAIL - does not have a valid DCO
 c0b3874 - FAIL - does not have a valid DCO
 a5e1ac3 - FAIL - does not have a valid DCO
 98dc567 - FAIL - does not have a valid DCO
 8b77050 - FAIL - does not have a valid DCO

I don't yet know how we could resolve this issue. Besides this, the commit should be fine now.

@vrothberg vrothberg mentioned this pull request Dec 10, 2018
Closed
@giuseppe
Copy link
Member

could you bump GITVALIDATE_EPOCH= in tests/validate/git-validation.sh?

@vrothberg
Copy link
Member Author

could you bump GITVALIDATE_EPOCH= in tests/validate/git-validation.sh?

At the moment it's on 25f4e8ec639044bff4ab393188d083782f07b61c but that's far behind the upper commits. I checked in #1231 if I can reproduce the issue but it doesn't look like I can.

@vrothberg
cli.BudFlags: add --platform nop
2452aa2 
Add the `--platform` option for Moby/Docker CLI-compat reasons.  This
option allows to control which platform (i.e., Windows or Linux) the
image will be build on and for.  Make this a nop as Buildah supports
only Linux.

Fixes: containers#629
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
bump GITVALIDATE_EPOCH
4f0d80d 
Set it to 87cb532 in order to ignore an
unsigned commit breaking CI.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
@giuseppe
Copy link
Member

LGTM

@vrothberg
Copy link
Member Author

Now it's a timeout in one test 🙅‍♂️ so close.

@rhatdan
Copy link
Member

rhatdan commented Dec 11, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 4f0d80d has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 4f0d80d with merge c8d6537...

rh-atomic-bot pushed a commit that referenced this pull request Dec 11, 2018
@vrothberg @rh-atomic-bot
cli.BudFlags: add --platform nop
96b2a15 
Add the `--platform` option for Moby/Docker CLI-compat reasons.  This
option allows to control which platform (i.e., Windows or Linux) the
image will be build on and for.  Make this a nop as Buildah supports
only Linux.

Fixes: #629
Signed-off-by: Valentin Rothberg <[email protected]>

Closes: #1230
Approved by: rhatdan
rh-atomic-bot pushed a commit that referenced this pull request Dec 11, 2018
@vrothberg @rh-atomic-bot
bump GITVALIDATE_EPOCH
c8d6537 
Set it to 87cb532 in order to ignore an
unsigned commit breaking CI.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>

Closes: #1230
Approved by: rhatdan
@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-travis

@rhatdan
Copy link
Member

rhatdan commented Dec 11, 2018

@rh-atomic-bot retry

@rh-atomic-bot
Copy link
Collaborator

⚡ Test exempted: pull fully rebased and already tested.

rh-atomic-bot pushed a commit that referenced this pull request Dec 11, 2018
@vrothberg @rh-atomic-bot
bump GITVALIDATE_EPOCH
90ea890 
Set it to 87cb532 in order to ignore an
unsigned commit breaking CI.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>

Closes: #1230
Approved by: rhatdan
@vrothberg vrothberg deleted the platform branch December 11, 2018 14:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vrothberg @TomSweeneyRedHat @giuseppe @rhatdan @rh-atomic-bot