Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildah silently fails to include non-OCI directives #2388

Closed
penn5 opened this issue Jun 2, 2020 · 1 comment · Fixed by #2622
Closed

Buildah silently fails to include non-OCI directives #2388

penn5 opened this issue Jun 2, 2020 · 1 comment · Fixed by #2622
Assignees
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR

Comments

@penn5
Copy link

penn5 commented Jun 2, 2020

Description

When running podman build . or buildah bud on a Dockerfile containing a HEALTHCHECK instruction, the healthcheck is silently ignored because it is not OCI-supported. It took me 4 hours to work out that I had to specify --format=docker, so am proposing that a warning is issued in this case

Steps to reproduce the issue:

  1. Create a Dockerfile containing a HEALTHCHECK
  2. Build it with buildah bud
  3. Observe that the Healthcheck is not included in the output of podman image inspect <image>

Describe the results you received:
Healthcheck is not included in the results

Describe the results you expected:
A warning is issued explaining why healthcheck is not included in the results and how to fix it (--format=docker)

Output of rpm -q buildah or apt list buildah:

buildah.x86_64            1.14.8-1.fc31                    updates

Output of buildah version:

$ buildah version
Version:         1.14.8
Go Version:      go1.13.9
Image Spec:      1.0.1-dev
Runtime Spec:    1.0.1-dev
CNI Spec:        0.4.0
libcni Version:  
image Version:   5.4.3
Git Commit:      
Built:           Thu Jan  1 01:00:00 1970
OS/Arch:         linux/amd64

Output of cat /etc/*release:

Fedora release 31 (Thirty One)
NAME=Fedora
VERSION="31 (KDE Plasma)"
ID=fedora
VERSION_ID=31
VERSION_CODENAME=""
PLATFORM_ID="platform:f31"
PRETTY_NAME="Fedora 31 (KDE Plasma)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:31"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f31/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=31
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=31
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="KDE Plasma"
VARIANT_ID=kde
Fedora release 31 (Thirty One)
Fedora release 31 (Thirty One)

Output of uname -a:

Linux toto 5.6.13-200.fc31.x86_64 #1 SMP Thu May 14 23:26:14 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Output of cat /etc/containers/storage.conf:

https://del.dog/amirirfude

@TomSweeneyRedHat
Copy link
Member

@penn5 Thanks for the issue. That's a good thought.

@TomSweeneyRedHat TomSweeneyRedHat changed the title Buildah silently fails to include non-OSI directives Buildah silently fails to include non-OCI directives Jun 2, 2020
@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Jun 2, 2020
bors bot added a commit that referenced this issue Sep 16, 2020
2616: build(deps): bump github.com/openshift/imagebuilder from 1.1.6 to 1.1.7 r=rhatdan a=dependabot-preview[bot]

Bumps [github.com/openshift/imagebuilder](https://github.com/openshift/imagebuilder) from 1.1.6 to 1.1.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/openshift/imagebuilder/releases">github.com/openshift/imagebuilder's releases</a>.</em></p>
<blockquote>
<h2>v1.1.7</h2>
<ul>
<li>Dockerfile/parser: Export node.Endline</li>
<li>Deduplicate environment variables</li>
<li>Update conformance tests</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/openshift/imagebuilder/commit/9491d0f6495b372680d198953d36484c88ee4801"><code>9491d0f</code></a> Bump to v1.1.7</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/3733e4752cf54a5e04dddb308ba1f554c18b78af"><code>3733e47</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/openshift/imagebuilder/issues/174">#174</a> from nalind/env-dederp</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/e99bf728da69d1fcf5a06e34820ddba7018b3cd6"><code>e99bf72</code></a> Fix accidentally discarding the environment for ENV</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/ac4334598b9508a1f889a7398c5e2a09b52a9e44"><code>ac43345</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/openshift/imagebuilder/issues/172">#172</a> from alvaroaleman/export-endline</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/72d7350d64a3de4516357d1029718ab1b631de2f"><code>72d7350</code></a> Dockerfile/parser: Export node.Endline</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/4faac48cfaea55fa0aaf39492c82e003947284d8"><code>4faac48</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/openshift/imagebuilder/issues/169">#169</a> from nalind/env-dedupe</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/936b56717b8ccfcbee895fbbdde78102d9f8e567"><code>936b567</code></a> Deduplicate environment variables</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/ef894eaa7136b2f47858b5e76f64192b7b5f5e2c"><code>ef894ea</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/openshift/imagebuilder/issues/171">#171</a> from nalind/conformance</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/82c947e6b4f01d60ee3d11a6587c5055a999604a"><code>82c947e</code></a> Update conformance tests</li>
<li><a href="https://github.com/openshift/imagebuilder/commit/0581584869b625591632cf580abd9d32a9da63b4"><code>0581584</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/openshift/imagebuilder/issues/168">#168</a> from TomSweeneyRedHat/v1.6</li>
<li>Additional commits viewable in <a href="https://github.com/openshift/imagebuilder/compare/v1.1.6...v1.1.7">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=github.com/openshift/imagebuilder&package-manager=go_modules&previous-version=1.1.6&new-version=1.1.7)](https://dependabot.com/compatibility-score/?dependency-name=github.com/openshift/imagebuilder&package-manager=go_modules&previous-version=1.1.6&new-version=1.1.7)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

2617: build(deps): bump github.com/containers/storage from 1.23.4 to 1.23.5 r=rhatdan a=dependabot-preview[bot]

Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.23.4 to 1.23.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/containers/storage/releases">github.com/containers/storage's releases</a>.</em></p>
<blockquote>
<h2>v1.23.5</h2>
<pre><code>For podman v2.0 we need to use use ignore_chown_errors field if set
utils_test.go: make test show mismatching items
Support the rootless storage path from the system file
build(deps): bump github.com/klauspost/compress from 1.10.11 to 1.11.0
</code></pre>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/containers/storage/commit/9da6416cdea4e26281c5552ea9628429679eab9d"><code>9da6416</code></a> Bump to v1.23.5</li>
<li><a href="https://github.com/containers/storage/commit/3f87836c7124653dcbbe905d71ed3302e1e9a631"><code>3f87836</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/storage/issues/713">#713</a> from rhatdan/master</li>
<li><a href="https://github.com/containers/storage/commit/b51c3ba2cd4c97eb0bac6741bbe9cf327cf92711"><code>b51c3ba</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/storage/issues/715">#715</a> from siretart/patch-2</li>
<li><a href="https://github.com/containers/storage/commit/98157c240a940bb5cf58239553b568733627f5ee"><code>98157c2</code></a> utils_test.go: make test show mismatching items</li>
<li><a href="https://github.com/containers/storage/commit/3c3285331d220e5571a82f96444db8e3e0c6a875"><code>3c32853</code></a> Support the rootless storage path from the system file</li>
<li><a href="https://github.com/containers/storage/commit/de3d59a92d4616dc9aa53b1e772baace67f795e9"><code>de3d59a</code></a> For podman v2.0 we need to use use ignore_chown_errors field if set</li>
<li><a href="https://github.com/containers/storage/commit/b837a4070d18ace78763406abe361fca0824bb6f"><code>b837a40</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/storage/issues/714">#714</a> from containers/dependabot/go_modules/github.com/klau...</li>
<li><a href="https://github.com/containers/storage/commit/858e1d55227261d3b529e2fcc4f9f246d5557e5a"><code>858e1d5</code></a> build(deps): bump github.com/klauspost/compress from 1.10.11 to 1.11.0</li>
<li><a href="https://github.com/containers/storage/commit/01ce1c303af6b7fadd08b5733bf4f83ddcda575b"><code>01ce1c3</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/storage/issues/708">#708</a> from rhatdan/VERSION</li>
<li><a href="https://github.com/containers/storage/commit/1757a8bcff60a0ad06be2402f7068ac907e852e4"><code>1757a8b</code></a> Move to v1.23.5-dev</li>
<li>See full diff in <a href="https://github.com/containers/storage/compare/v1.23.4...v1.23.5">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=github.com/containers/storage&package-manager=go_modules&previous-version=1.23.4&new-version=1.23.5)](https://dependabot.com/compatibility-score/?dependency-name=github.com/containers/storage&package-manager=go_modules&previous-version=1.23.4&new-version=1.23.5)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Ashley Cui <[email protected]>
bors bot added a commit that referenced this issue Sep 16, 2020
2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




2624: Fix buildah mount to display container names not ids r=rhatdan a=rhatdan

Currently we are displaying containerid rather then containername,
which is unknown to users.  Users refer to the container names all
of the time, so we should show the mounted containers based on names.

This change eliminates the need for the truncate flag on buildah mount
as well, so this PR hides it.

Fix up the man page documentation to use container names and show
proper output.

Signed-off-by: Daniel J Walsh <[email protected]>

<!--
Thanks for sending a pull request!

Please make sure you've read and understood our contributing guidelines
(https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring
that all your commits are signed with `git commit -s`.
-->

#### What type of PR is this?

<!--
Please label this pull request according to what type of issue you are
addressing, especially if this is a release targeted pull request.

Uncomment only one `/kind <>` line, hit enter to put that in a new line, and
remove leading whitespace from that line:
-->

> /kind api-change
> /kind bug
> /kind cleanup
> /kind deprecation
> /kind design
> /kind documentation
> /kind failing-test 
> /kind feature
> /kind flake
> /kind other

#### What this PR does / why we need it:

#### How to verify it

#### Which issue(s) this PR fixes:

<!--
Automatically closes linked issue when PR is merged.
Uncomment the following comment block and include the issue
number or None on one line.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`.
-->

<!--
Fixes #
or
None
-->

#### Special notes for your reviewer:

#### Does this PR introduce a user-facing change?

<!--
If no, just write `None` in the release-note block below. If yes, a release note
is required: Enter your extended release note in the block below. If the PR
requires additional action from users switching to the new release, include the
string "action required".

For more information on release notes please follow the kubernetes model:
https://git.k8s.io/community/contributors/guide/release-notes.md
-->

```release-note

```



Co-authored-by: Ashley Cui <[email protected]>
Co-authored-by: Daniel J Walsh <[email protected]>
bors bot added a commit that referenced this issue Sep 16, 2020
2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




Co-authored-by: Ashley Cui <[email protected]>
bors bot added a commit that referenced this issue Sep 16, 2020
2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




Co-authored-by: Ashley Cui <[email protected]>
bors bot added a commit that referenced this issue Sep 16, 2020
2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




Co-authored-by: Ashley Cui <[email protected]>
bors bot added a commit that referenced this issue Sep 16, 2020
2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




Co-authored-by: Ashley Cui <[email protected]>
bors bot added a commit that referenced this issue Sep 17, 2020
2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




Co-authored-by: Ashley Cui <[email protected]>
bors bot added a commit that referenced this issue Sep 17, 2020
2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




Co-authored-by: Ashley Cui <[email protected]>
bors bot added a commit that referenced this issue Sep 21, 2020
2622: Warn when setting healthcheck in OCI format r=rhatdan a=ashley-cui

Signed-off-by: Ashley Cui <[email protected]>

#### What type of PR is this?
/kind other

#### What this PR does / why we need it:
Healthcheck only works in Docker format, so when healthcheck is set in OCI format, warn user that it will be discarded
#### How to verify it

#### Which issue(s) this PR fixes:
Fixes: #2388




2640: build(deps): bump github.com/containers/image/v5 from 5.5.2 to 5.6.0 r=rhatdan a=dependabot-preview[bot]

Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.5.2 to 5.6.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/containers/image/releases">github.com/containers/image/v5's releases</a>.</em></p>
<blockquote>
<h2>v5.6.0</h2>
<ul>
<li>When we can't store signatures, point the user at the destination.</li>
<li>Update for <a href="https://github-redirect.dependabot.com/containers/skopeo/issues/932">containers/skopeo#932</a></li>
<li>Refactor configPath API</li>
<li>Load the rootless registries.conf.d for override</li>
<li>docker config: clean up after test</li>
<li>blobinfocache: clean up after test</li>
<li>enable search using pagination</li>
<li>pkg/docker/config: correct default file mode when create auth.json file</li>
<li>Update to Go 1.13</li>
<li>Coverity found potential nil dereference</li>
<li>Look for normalized paths in tarfile.</li>
<li>Move docker/tarfile.Destination to docker/internal/tarfile.Destination</li>
<li>Use the docker/internal/tarfile.Destination from docker/daemon and docker/archive</li>
<li>Remove deprecated non-SystemContext functions from docker/internal.tarfile</li>
<li>Introduce Destination.configPath and Destination.physicalLayerPath</li>
<li>Split docker/internal.tarfile.Writer from Destination</li>
<li>Move createRepositoriesFile to a bit better place</li>
<li>Split Writer.createManifest from Destination.PutManifest</li>
<li>Reorganize docker/internal/tarfile.Writer.createManifest a bit</li>
<li>Move the computation of layerPaths in docker-archive</li>
<li>Implement writing multiple images in the modern format.</li>
<li>Split createSingleLegacyLayer from writeLegacyLayerMetadata</li>
<li>Move legacy layer ID computation to a bit later</li>
<li>Merge writeLegacyMetadata and createRepositoriesFile</li>
<li>Implement writing multiple images in the legacy format</li>
<li>Separate tarfile.Writer creation from Destination creation</li>
<li>Lock docker/internal/tarfile.Writer to support concurrent uses</li>
<li>Split openArchiveForWriting from docker/archive/newImageDestination</li>
<li>Finally, introduce docker/archive.Writer</li>
<li>use container/storage/pkg/homedir</li>
<li>Fix an error message on docker-archive:path:name@sha256:$digest</li>
<li>Move docker/tarfile.Source to docker/internal/tarfile.Source</li>
<li>Use the docker/internal/tarfile.Source from docker/daemon and docker/archive</li>
<li>Remove deprecated non-SystemContext functions from docker/internal/tarfile</li>
<li>Split docker/internal/tarfile.Reader from Source</li>
<li>Separate tarfile.Reader creation from Source creation</li>
<li>Read the tarfile manifest already when initializing tarfile.Reader</li>
<li>Turn tarfile.Source.LoadTarManifest into a TarManifest</li>
<li>Allow choosing an image from tarfile.Reader by reference</li>
<li>Introduce docker-archive:path:<a href="https://github.com/Index">@Index</a> syntax for reading untagged images</li>
<li>Introduce docker/archive.Reader</li>
<li>Finally, share a tarfile.Reader across archiveSource objects</li>
<li>Add docker/archive.NewReaderForReference</li>
<li>Add docker/archive.Reader.ManifestTagsForReference</li>
<li>Support per user registries.d</li>
<li>Move TestInvalidPolicyFormatError</li>
<li>Reduce duplication in policy_config_test.go</li>
<li>Eliminate more duplication in signature/policy_config_tests.go</li>
<li>Return error body if UnexpectedHTTPResponseError</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/containers/image/commit/4f7144c652b52417093593c99610de1d4adc8092"><code>4f7144c</code></a> v5.6.0</li>
<li><a href="https://github.com/containers/image/commit/c8061156815bdddf4e9bffb4c8a2b26d49dcc7b7"><code>c806115</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/image/issues/1044">#1044</a> from containers/dependabot/go_modules/github.com/con...</li>
<li><a href="https://github.com/containers/image/commit/b3df60ead31034399947fc3be0b9e78e18c6ce15"><code>b3df60e</code></a> Bump github.com/containers/storage from 1.23.4 to 1.23.5</li>
<li><a href="https://github.com/containers/image/commit/18b976011b11181042dc76763c780b05cd47aebe"><code>18b9760</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/image/issues/1040">#1040</a> from containers/dependabot/go_modules/github.com/con...</li>
<li><a href="https://github.com/containers/image/commit/a771cba5b4a9c274c88a58a7d3efbf43c5730281"><code>a771cba</code></a> Bump github.com/containers/storage from 1.23.3 to 1.23.4</li>
<li><a href="https://github.com/containers/image/commit/6edae75b24f1270a1402964942e19076f153c53a"><code>6edae75</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/image/issues/1038">#1038</a> from containers/dependabot/go_modules/github.com/kla...</li>
<li><a href="https://github.com/containers/image/commit/a9088a36d0012848392ab80d6de901a0a007fa5e"><code>a9088a3</code></a> Bump github.com/klauspost/pgzip from 1.2.4 to 1.2.5</li>
<li><a href="https://github.com/containers/image/commit/2a714d7108b1bb02b58597466ab73370b4110cf6"><code>2a714d7</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/image/issues/1042">#1042</a> from containers/dependabot/go_modules/github.com/kla...</li>
<li><a href="https://github.com/containers/image/commit/22dea1132d31c31251ab57a1e91794349da4f727"><code>22dea11</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/containers/image/issues/1039">#1039</a> from QiWang19/untar</li>
<li><a href="https://github.com/containers/image/commit/1b1d2f6794cde011b6bb8a27485a43724c73253b"><code>1b1d2f6</code></a> Set NoLchown to true in untar opts</li>
<li>Additional commits viewable in <a href="https://github.com/containers/image/compare/v5.5.2...v5.6.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=github.com/containers/image/v5&package-manager=go_modules&previous-version=5.5.2&new-version=5.6.0)](https://dependabot.com/compatibility-score/?dependency-name=github.com/containers/image/v5&package-manager=go_modules&previous-version=5.5.2&new-version=5.6.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>

Co-authored-by: Ashley Cui <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@bors bors bot closed this as completed in 0e06e45 Sep 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants