Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildah push to containers-storage generate different image ID when push the same image several times #223

Closed
gouyang opened this issue Jul 27, 2017 · 8 comments

Comments

@gouyang
Copy link

gouyang commented Jul 27, 2017

[root@fedora ~]# buildah images
IMAGE ID             IMAGE NAME                                               CREATED AT             SIZE
76cca0563a1f         docker.io/library/nginx:latest                           Jul 26, 2017 07:47     102.5 MB
571a23b3f2ae         docker.io/library/fedora:26                              Jul 27, 2017 01:04     219.9 MB
0a713cf400a8                                                                  Jul 27, 2017 09:21     1.079 MB
0a713cf400a8         <none>                                                   Jul 27, 2017 09:21     1.079 MB
da7d318078a9                                                                  Jul 27, 2017 09:22     1.079 MB
da7d318078a9         <none>                                                   Jul 27, 2017 09:22     1.079 MB
41a40ea1a30d                                                                  Jul 27, 2017 09:22     1.079 MB
41a40ea1a30d         <none>                                                   Jul 27, 2017 09:22     1.079 MB
77fd5916b09a         docker.io/library/busybox:latest                         Jul 27, 2017 09:23     1.079 MB
[root@fedora ~]# crioctl image list
ID: 76cca0563a1f28f2b3fd56c63462346f39827b4f539a16d27992f04eaf5c608f
Tag: docker.io/library/nginx:latest
ID: 571a23b3f2ae38358a3bde3a1f3c44ed4cbde9df1e1a1753fbc4e1c13ba7038c
Tag: docker.io/library/fedora:26
ID: 0a713cf400a8b9fecb6ae60f3d51204ac792773e62df61797d7930310faf085e
ID: da7d318078a9a39c09fec64175839359ef50bd74d384085d7c49afc3a63caf9d
ID: 41a40ea1a30dad81e9713fe8d7b7609b1e9add7c68dc670b456e7350cb56c8ff
ID: 77fd5916b09ae666de05c2313b9aa7b3e09cebfb423f8787ad1a5e7953d86b8a
Tag: docker.io/library/busybox:latest
@gouyang gouyang changed the title buildah push generate multiple image ID when push to containers-storage buildah push to containers-storage generate different image ID when push the same image several times Jul 27, 2017
@gouyang
Copy link
Author

gouyang commented Jul 27, 2017

Push the same image to docker-daemon several times, it's just one image ID shows in docker images

@rhatdan
Copy link
Member

rhatdan commented Jul 27, 2017

@nalind Is this something your storage work is going to fix?

@nalind
Copy link
Member

nalind commented Jul 27, 2017

Yes, this is something that should be fixed by containers/image#305.

@nalind
Copy link
Member

nalind commented Jul 27, 2017

Just to be clear, what's the command you're using to push the image?

@gouyang
Copy link
Author

gouyang commented Jul 27, 2017

the command should be buildah push docker.io/library/nginx:latest containers-storage:docker.io/library/nginx:latest

@boaz0
Copy link
Collaborator

boaz0 commented Jan 1, 2018

ping @nalind - can I close this ticket as containers/image#305 fixes it?

@gouyang
Copy link
Author

gouyang commented Jan 2, 2018

Tested it, the problem goes alway

[root@fedora buildah]# ./buildah push docker.io/library/nginx:latest containers-storage:docker.io/library/nginx:latest
Getting image source signatures
Skipping fetch of repeat blob sha256:2ec5c0a4cb57c0af7c16ceda0b0a87a54f01f027ed33836a5669ca266cafe97a
Skipping fetch of repeat blob sha256:73e2bd4455140950d98430338783415109e4c4dcf955681d334b312b176d964a
Skipping fetch of repeat blob sha256:a103d141fc9823f04f30d1e71705001577eab94df7ac594e5e49f64e2e506c8b
Copying config sha256:3f8a4339aadda5897b744682f5f774dc69991a81af8d715d37a616bb4c99edf5
 5.70 KiB / 5.70 KiB [======================================================] 0s
Writing manifest to image destination
Storing signatures

[root@fedora buildah]# crictl  images
IMAGE                     TAG                 IMAGE ID            SIZE
docker.io/library/nginx   latest              3f8a4339aadda       6.59kB
[root@fedora buildah]# ./buildah push docker.io/library/nginx:latest containers-storage:docker.io/library/nginx:latest
Getting image source signatures
Skipping fetch of repeat blob sha256:2ec5c0a4cb57c0af7c16ceda0b0a87a54f01f027ed33836a5669ca266cafe97a
Skipping fetch of repeat blob sha256:73e2bd4455140950d98430338783415109e4c4dcf955681d334b312b176d964a
Skipping fetch of repeat blob sha256:a103d141fc9823f04f30d1e71705001577eab94df7ac594e5e49f64e2e506c8b
Copying config sha256:3f8a4339aadda5897b744682f5f774dc69991a81af8d715d37a616bb4c99edf5
 5.70 KiB / 5.70 KiB [======================================================] 0s
Writing manifest to image destination
Storing signatures

[root@fedora buildah]# crictl  images
IMAGE                     TAG                 IMAGE ID            SIZE
docker.io/library/nginx   latest              3f8a4339aadda       6.59kB

@gouyang gouyang closed this as completed Jan 2, 2018
@boaz0
Copy link
Collaborator

boaz0 commented Jan 2, 2018

thanks @gouyang

nalind pushed a commit that referenced this issue Apr 2, 2018
If we start a container and it does not error, we can assume the
container is now running. Subsequent API calls will sync for us
to see if it died, so we can just set ContainerStateRunning
instead of launching the runtime to explicitly get state.

The same logic applies to pause and unpause.

Signed-off-by: Matthew Heon <[email protected]>

Closes: #223
Approved by: rhatdan
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants