Skip to content

Commit

Permalink
rename 'is' to 'expect_output'
Browse files Browse the repository at this point in the history
...and make the "$output" argument implicit, as well as the
description text. This greatly simplifies its invocation.

Also: make it test for exact matches unless --substring
option is passed; this eases my mind about a few potentially
ambiguous situations such as the one in #1464.

Also: add comments to two truth-table check functions

Also: reorder some config checks alphabetically, for ease
of reading.

Thanks to Tom Sweeney for the suggestions and encouragement.

Signed-off-by: Ed Santiago <[email protected]>

Closes: #1492
Approved by: rhatdan
  • Loading branch information
edsantiago authored and rh-atomic-bot committed Apr 9, 2019
1 parent f7f0839 commit 021d607
Show file tree
Hide file tree
Showing 19 changed files with 243 additions and 214 deletions.
2 changes: 1 addition & 1 deletion tests/basic.bats
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,5 @@ load helpers
[ "$output" != "" ]
run_buildah rmi -a
run_buildah --debug=false images -q
is "$output" "" "output from buildah images -q"
expect_output ""
}
Loading

0 comments on commit 021d607

Please sign in to comment.