tests: Drop internal-testing-api, move to tests-integration
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
testing
branch
3 times, most recently
from
a9775a5 to
b5eee54
Compare
Previous work started moving our tests into an external binary; this is just cleaner because it can test things how a user would test. Also, we started using `libtest-mimic` to have a "real" test scaffolding that e.g. allows selecting individual tests to run, etc. Complete the picture here by moving the remaining bits into the tests-integration binary. We now run the `tests-integration` binary in two ways in e.g. Github Actions: - It's compiled directly on the Ubuntu runner, and orchestrates things itself - It's built in our default container image (Fedora) but as an external `/usr/bin/bootc-integration-tests` binary Also while we're here, drop the kola tests. Signed-off-by: Colin Walters <[email protected]>
jmarrero
approved these changes
Jun 4, 2024
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
Release 0.2.15
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 6, 2024
lib: Make image configuration always present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous work started moving our tests into an external binary; this is just cleaner because it can test things how a user would test. Also, we started using
libtest-mimicto have a "real" test scaffolding that e.g. allows selecting individual tests to run, etc.Complete the picture here by moving the remaining bits into the tests-integration binary. We now run the
tests-integrationbinary in two ways in e.g. Github Actions:/usr/bin/bootc-integration-testsbinaryAlso while we're here, drop the kola tests.