-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: some updates on test #552
Conversation
(Huh, weird that you hit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6b96dab
to
79852fb
Compare
b07f634
to
fe9de8b
Compare
We're running a lot of tests per PR today, I'm not sure always need to all these tests per PR. Maybe we can move some of them to post-merge testing? For example testing both c9s and rhel9.4 makes sense, but I'm not sure about every PR. Similarly both x86_64 and aarch64. I'd like to be able to opt-in (via a comment or label on a PR) to full testing, but my instinct here is to ensure we have baseline sanity testing to start...and what do you think about ensuring that if say we choose to say only test aarch64 on a PR for c9s (skipping x86_64) we are diligently watching post-merge testing and can quickly identify any breakage? |
I totally agree with you. Our daily test covered much more. We can catch failure with daily test. What about the plan like this:
|
Let's drop fedora 41 there: I don't want to gate PRs on fedora rawhide stability. Or to future proof it the matrix would just have fedora $stable. We can also pretty confidently drop 9.4 I think for PR testing, the chance that we pass on 9.5 but break on 9.4 is currently very close to zero. |
1. add bootc swtich test 2. add bootc install to-disk test 3. cover more distros, like rhel 9.5, fedora 40 and 41(rawhide) Signed-off-by: Xiaofeng Wang <[email protected]>
This is a huge PR. Is it possible to break it into smaller PRs such that it is less risky and easier to review? |
It's not easy to split this PR now. :-) I run this PR with testing farm. That can avoid test issue imported by this PR.
This PR is ready to merge now. |
lib/container: Add APIs to retrieve version conveniently
bootc swtich
test. Switch to local folder/mnt
in this casebootc install to-disk
testinstalling SELinux-enabled targets from SELinux-disabled hosts
for Ensure no-selinux case is at least e2e tested periodically #419rhel 9.5
,fedora 40
andfedora 41(rawhide)
testing-farm-as-github-action
to v2