deploy: Add number of layers to fetch progress #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a `{prefix}` in the template, but nothing was set. Let's
print the number of layers.
Now, in theory this should be a fix to ostree-ext, but
doing so would require a Rust API change, and anyways
in the future we want to switch to podman pulls anyways.
Signed-off-by: Colin Walters <[email protected]>
cgwalters
commented
May 13, 2024
| @@ -113,6 +113,55 @@ pub(crate) fn check_bootc_label(config: &ostree_ext::oci_spec::image::ImageConfi | |||
| } | |||
| } | |||
|
|
|||
| /// Write container fetch progress to standard output. | |||
| async fn handle_layer_progress_print( | |||
There was a problem hiding this comment.
See https://github.com/ostreedev/ostree-rs-ext/blob/9a4743a657ffe0435018d9720c6df80a486ca0f1/lib/src/cli.rs#L566 from which this forked to add the layer count.
|
Please ignore rhel 9.4 integration test failure. The new |
jeckersb
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM, sanity checked it works as expected:
[root@ibm-p8-kvm-03-guest-02 ~]# ./bootc switch quay.io/centos-bootc/centos-bootc:stream9
layers already present: 0; layers needed: 66 (835.7 MB)
[24/66] 1.33 MiB [███████░░░░░░░░░░░░░] (0s) Fetching ostree chunk sha256:594c21b0ae2a (3.5 MB)
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 6, 2024
lib: Require new containers-image-proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a
{prefix}in the template, but nothing was set. Let's print the number of layers.Now, in theory this should be a fix to ostree-ext, but doing so would require a Rust API change, and anyways in the future we want to switch to podman pulls anyways.