Skip to content

Commit

Permalink
Merge pull request #1020 from jeckersb/961-followup
Browse files Browse the repository at this point in the history
Typo fixup for #961
  • Loading branch information
cgwalters authored Jan 9, 2025
2 parents 255b743 + 3875368 commit de43563
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/src/experimental-progress-fd.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This is an experimental feature; tracking issue: <https://github.com/containers/
While the `bootc status` tooling allows a client to discover the state
of the system, during interactive changes such as `bootc upgrade`
or `bootc switch` it is possible to monitor the status of downloads
or other operations at a fine-grained level with `-progress-fd`.
or other operations at a fine-grained level with `--progress-fd`.

The format of data output over `--progress-fd` is [JSON Lines](https://jsonlines.org)
which is a series of JSON objects separated by newlines (the intermediate
Expand All @@ -29,4 +29,4 @@ Importing and staging are affected by disk speed and the total image size. Pulli
is affected by network speed and how many layers invalidate between pulls.
Therefore, a large image with a good caching strategy will have longer
importing and staging times, and a small bespoke container image will have
negligible importing and staging times.
negligible importing and staging times.
2 changes: 1 addition & 1 deletion lib/src/progress_jsonl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ impl ProgressWriter {
}

// For messages that can be dropped, if we already sent an update within this cycle, discard this one.
// TODO: Also consider querying the pipe buffer and also dropping if wqe can't do this write.
// TODO: Also consider querying the pipe buffer and also dropping if we can't do this write.
let now = Instant::now();
if !required {
const REFRESH_MS: u32 = 1000 / REFRESH_HZ as u32;
Expand Down

0 comments on commit de43563

Please sign in to comment.