Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused packages and update python versions #376

Merged

Conversation

inknos
Copy link
Collaborator

@inknos inknos commented Aug 14, 2024

python-xdg was removed as a dependency
containers/podman-py@8d1020e

tests are currently done for py12
containers/podman-py@330cf0b

@inknos inknos requested a review from cevich August 14, 2024 13:03
@cevich
Copy link
Member

cevich commented Aug 14, 2024

Hrmm, seems like you did things correctly, checking why it failed.

Also FYI: If you force-push/cancel any running VM build tasks are still running, they sometimes (annoyingly/unfortunately) leave behind running VMs that need to be manually cleaned up. If it happens now/again it's fine, just letting you know.

@cevich
Copy link
Member

cevich commented Aug 14, 2024

I re-ran the two failed container image build tasks. They failed due to a quay.io flake:

"Error: writing blob: initiating layer upload to /v2/libpod/ccia/blobs/uploads/ in quay.io: received unexpected HTTP status: 502 Bad Gateway"

This has been a long-term issue others on the team are very familiar with.

Copy link

Cirrus CI build successful. Found built image names and IDs:

Stage Image Name IMAGE_SUFFIX
base debian do-not-use
base fedora do-not-use
base fedora-aws do-not-use
base fedora-aws-arm64 do-not-use
base image-builder do-not-use
base prior-fedora do-not-use
cache build-push c20240814t130155z-f40f39d13
cache debian c20240814t130155z-f40f39d13
cache fedora c20240814t130155z-f40f39d13
cache fedora-aws c20240814t130155z-f40f39d13
cache fedora-netavark c20240814t130155z-f40f39d13
cache fedora-netavark-aws-arm64 c20240814t130155z-f40f39d13
cache fedora-podman-aws-arm64 c20240814t130155z-f40f39d13
cache fedora-podman-py c20240814t130155z-f40f39d13
cache prior-fedora c20240814t130155z-f40f39d13
cache rawhide c20240814t130155z-f40f39d13
cache win-server-wsl c20240814t130155z-f40f39d13

@edsantiago
Copy link
Member

debian prior-fedora fedora fedora-aws rawhide
kernel 6.10.4-1 6.5.6-300 6.8.5-301 6.8.5-301 6.8.5-301
6.9.12-1 ⇑ 6.9.12-100 ⇑ 6.9.12-200 ⇑ 6.9.12-200 ⇑
grub2-common 2.12-5 2.06-121 2.06-123 2.06-123 2.12-4
2.06-124 ⇑
aardvark-dns 1.9.0-2 1.11.0-1 1.12.1-1 1.12.1-1 1.12.1-1
1.6.0-3 ⇑ 1.11.0-3 ⇑
netavark 1.9.0-4 1.11.0-1 1.12.1-1 1.12.1-1 1.12.1-1
1.6.0-2.1 ⇑ 1.11.0-3 ⇑ 1.11.0-3 ⇑
buildah 1.35.3+ds1-3+b1 1.37.0-1 1.37.0-1 1.37.0-1 1.37.0-1
1.35.3+ds1-3 ⇑ 1.36.0-1 ⇑ 1.36.0-1 ⇑
containers-common ? 1-99 0.60.1-1 0.60.0-1 0.60.1-1
0.60.0-1 ⇑ 0.60.0-1 ⇑
crun 1.16-1 1.15-1 1.15-1 1.15-1 1.15-2
1.15-1 ⇑
docker-ce 5:27.1.2-1~debian.12~bookworm ? ? ? ?
5:27.1.1-1~debian.12~bookworm ⇑
gvisor-tap-vsock ? 0.7.4-1 ? ? ?
0.7.3-1 ⇑
passt 2024-08-06 2024-06-24 2024-08-06 2024-08-06 2024-08-06
2024-07-26 ⇑ 2024-07-26 ⇑ 2024-06-24 ⇑ 2024-07-26 ⇑
podman 5.0.3+ds1-5+b2 4.9.4-1 5.2.0-1 5.2.0-1 5.2.0-1
5.0.3+ds1-5 ⇑ 5.1.2-1 ⇑ 5.2.0~rc2-1 ⇑
runc 1.1.12+ds1-2+b1 1.1.12-1 1.1.12-3 1.1.12-3 1.1.12-4
1.1.12+ds1-2 ⇑
skopeo 1.13.3+ds1-2+b2 1.15.2-1 1.16.0-1 1.15.2-1 1.16.0-1
1.13.3+ds1-2+b1 ⇑
systemd 256.4-3 254.16-1 255.10-3 255.10-3 256.4-1
256.4-2 ⇑ 255.10-1 ⇑ 255.10-1 ⇑

@edsantiago
Copy link
Member

@inknos are you familiar with protocols here? Will you be following up with podman/buildah/etc test PRs?

@cevich
Copy link
Member

cevich commented Aug 14, 2024

I met with him the other day, he's going to need some guidance. My understanding is the intent is to use the new fedora-podman-py image in the podman-py repo. Though testing elsewhere won't hurt anything, I think his plans are bigger than just the image.

Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inknos
Copy link
Collaborator Author

inknos commented Aug 15, 2024

@edsantiago if you would help me out taking over from where we stopped with Chris I would be glad to learn the process and open the PRs

@edsantiago
Copy link
Member

It's easy! At least in theory. It's also tedious.

  1. Go to whichever repo is most at risk by this change. Typically that's podman, but in this case Chris says you intend this for podman-py so that could be a good starting point. Also, docker changed, so you'll need to test this on buildah.
  2. Edit .cirrus.yml. Search for c202. Replace that entire string with the c202 string from this PR.
  3. Submit a PR to that repo with only that change.
  4. See what breaks. Please feel free to ask for help -- this part of the process can take days to resolve.

HTH

@inknos inknos force-pushed the update-python-versions-and-packages branch from 4ccb143 to 3e37ec4 Compare September 19, 2024 14:55
@inknos
Copy link
Collaborator Author

inknos commented Sep 19, 2024

I am rebasing this and trying to make it work now that tests for podman-py are green again

Copy link

Cirrus CI build successful. Found built image names and IDs:

Stage Image Name IMAGE_SUFFIX
base debian do-not-use
base fedora do-not-use
base fedora-aws do-not-use
base fedora-aws-arm64 do-not-use
base image-builder do-not-use
base prior-fedora do-not-use
cache build-push c20240919t145433z-f40f39d13
cache debian c20240919t145433z-f40f39d13
cache fedora c20240919t145433z-f40f39d13
cache fedora-aws c20240919t145433z-f40f39d13
cache fedora-netavark c20240919t145433z-f40f39d13
cache fedora-netavark-aws-arm64 c20240919t145433z-f40f39d13
cache fedora-podman-aws-arm64 c20240919t145433z-f40f39d13
cache fedora-podman-py c20240919t145433z-f40f39d13
cache prior-fedora c20240919t145433z-f40f39d13
cache rawhide c20240919t145433z-f40f39d13
cache win-server-wsl c20240919t145433z-f40f39d13

@edsantiago
Copy link
Member

debian prior-fedora fedora fedora-aws rawhide
grub2-common 2.12-5 2.06-121 2.06-123 2.06-123 2.12-7
2.12-4 ⇑
buildah 1.37.2+ds1-3 1.37.1-1 1.37.1-1 1.37.1-1 1.37.2-2
1.37.2-1 ⇑
conmon 2.1.10+ds1-1+b1 2.1.12-1 2.1.12-2 2.1.12-2 2.1.12-3
2.1.12-2 ⇑
container-selinux ? 2.232.1-1 2.233.0-1 2.233.0-1 2.233.0-1
2.232.1-1 ⇑ 2.232.1-1 ⇑ 2.232.1-2 ⇑
golang 2:1.23~2 1.21.12-1 1.22.7-1 1.22.7-1 1.23.1-1
2:1.22~3 ⇑ 1.22.6-1 ⇑ 1.22.6-1 ⇑ 1.23.0-2 ⇑
gvisor-tap-vsock ? 0.7.5-1 ? ? ?
0.7.4-1 ⇑
podman 5.2.2+ds1-4 4.9.4-1 5.2.2-1 5.2.2-1 5.2.2-2
5.2.2+ds1-2 ⇑ 5.2.2-1 ⇑
runc 1.1.12+ds1-5+b1 1.1.12-1 1.1.12-3 1.1.12-3 1.1.12-4
1.1.12+ds1-5 ⇑
skopeo 1.16.1+ds1-1 1.16.1-1 1.16.1-1 1.16.1-1 1.16.1-2
1.13.3+ds1-2+b2 ⇑ 1.16.1-1 ⇑
systemd 256.6-1 254.16-1 255.12-1 255.12-1 256.5-1
255.10-3 ⇑ 255.10-3 ⇑

@edsantiago
Copy link
Member

@inknos what is the status of these images? Have you been able to test them?

@inknos
Copy link
Collaborator Author

inknos commented Sep 26, 2024

@edsantiago unfortunately I can't figure out why the tests in the PR seem broken. Could you help me with that?

@edsantiago
Copy link
Member

@inknos ping, what is the status of this PR?

python-xdg was removed as a dependency
containers/podman-py@8d1020e

tests are currently done for py12
containers/podman-py@330cf0b

Signed-off-by: Nicola Sella <[email protected]>
@inknos inknos force-pushed the update-python-versions-and-packages branch from 3e37ec4 to 9301643 Compare October 15, 2024 08:55
Copy link

Cirrus CI build successful. Found built image names and IDs:

Stage Image Name IMAGE_SUFFIX
base debian do-not-use
base fedora do-not-use
base fedora-aws do-not-use
base fedora-aws-arm64 do-not-use
base image-builder do-not-use
base prior-fedora do-not-use
cache build-push c20241015t085508z-f40f39d13
cache debian c20241015t085508z-f40f39d13
cache fedora c20241015t085508z-f40f39d13
cache fedora-aws c20241015t085508z-f40f39d13
cache fedora-netavark c20241015t085508z-f40f39d13
cache fedora-netavark-aws-arm64 c20241015t085508z-f40f39d13
cache fedora-podman-aws-arm64 c20241015t085508z-f40f39d13
cache fedora-podman-py c20241015t085508z-f40f39d13
cache prior-fedora c20241015t085508z-f40f39d13
cache rawhide c20241015t085508z-f40f39d13
cache win-server-wsl c20241015t085508z-f40f39d13

@edsantiago
Copy link
Member

debian prior-fedora fedora fedora-aws rawhide
grub2-common 2.12-5 2.06-121 2.06-123 2.06-123 2.12-9
2.12-7 ⇑
criu 3.17.1-3 4.0-1 4.0-1 4.0-1 4.0-1
3.19-2 ⇑ 3.19-4 ⇑
golang 2:1.23~2 1.22.8-1 1.22.7-1 1.22.7-1 1.23.2-2
1.22.7-3 ⇑
systemd 256.7-1 254.18-1 255.13-1 255.13-1 256.7-1
255.12-1 ⇑ 255.12-1 ⇑ 256.5-1 ⇑

@edsantiago
Copy link
Member

Okay now repush or resubmit your test PR on the podman-py repo, and report results back here.

From a quick look in cache_images and .cirrus.yml it looks like this change should not affect any other container repo, do you agree?

@inknos
Copy link
Collaborator Author

inknos commented Oct 15, 2024

Done. I agree, this should only touch python, so podman-py is the only one affected

@edsantiago
Copy link
Member

OK, good. But criu and systemd changed, and criu is a known-bad version, so please also submit a podman PR changing the c2024 string. Be sure to cross-reference to this PR and back; see #23706 for a trivial example. If you're very lucky, the c2024 change is the only one you will need to make.

inknos added a commit to inknos/podman that referenced this pull request Oct 15, 2024
inknos added a commit to inknos/podman-py that referenced this pull request Oct 15, 2024
@inknos
Copy link
Collaborator Author

inknos commented Oct 15, 2024

Testing prs open:

containers/podman-py#430

containers/podman#24270

@edsantiago
Copy link
Member

podman-py and podman PRs passed and merged.

@edsantiago edsantiago merged commit a478e68 into containers:main Oct 15, 2024
41 checks passed
Honny1 pushed a commit to Honny1/podman-py that referenced this pull request Oct 15, 2024
containers/automation_images#376

Signed-off-by: Nicola Sella <[email protected]>
(cherry picked from commit fd601b2)
Signed-off-by: Jan Rodák <[email protected]>
Honny1 pushed a commit to Honny1/podman-py that referenced this pull request Oct 16, 2024
containers/automation_images#376

Signed-off-by: Nicola Sella <[email protected]>
(cherry picked from commit fd601b2)
Signed-off-by: Jan Rodák <[email protected]>
Honny1 pushed a commit to Honny1/podman-py that referenced this pull request Oct 16, 2024
containers/automation_images#376

Signed-off-by: Nicola Sella <[email protected]>
(cherry picked from commit fd601b2)
inknos added a commit to inknos/podman-py that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants