[CI:DOCS] Resolve TODO: human-readable image-suffixes #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This validate failure is expected. it will go away once #247 is merged and this PR is rebased. |
cevich
commented
Jan 27, 2023
cevich
force-pushed
the
versionable_suffixes_two
branch
4 times, most recently
from
89b9efd to
208894c
Compare
cevich
changed the title
cevich
force-pushed
the
versionable_suffixes_two
branch
2 times, most recently
from
e0bbcf5 to
6950877
Compare
|
Example image-build PR (no magic |
|
Example image-build PR w/ updated IMG_SFX file: https://cirrus-ci.com/task/4728253965926400 |
cevich
force-pushed
the
versionable_suffixes_two
branch
from
8fd5be1 to
8ab7de0
Compare
|
Example of image-build PR where IMG_SFX was updated backwards in time: ...failed. It allowed build to continue 😢 |
cevich
force-pushed
the
versionable_suffixes_two
branch
from
8ab7de0 to
755e60f
Compare
|
Example of image-build PR with IMG_SFX going backwards in time: https://cirrus-ci.com/task/6738409188753408 (expected failure) |
cevich
changed the title
cevich
force-pushed
the
versionable_suffixes_two
branch
from
a605f14 to
7db06b5
Compare
|
@edsantiago this is probably not completely the most efficient way to do things, but testing shows it seems to function as intended. PTAL when you get a chance. |
edsantiago
reviewed
Jan 30, 2023
This conditional was required temporarily so PR containers#247 could merge. Remove and replace it with a version that avoids modifying any files and only checks if `IMG_SFX` changes were made. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
versionable_suffixes_two
branch
from
7db06b5 to
43fa788
Compare
|
Force-push: One little |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditional was required temporarily so #247 could merge. Remove
and replace it with a version that avoids modifying any files and only
checks if
IMG_SFXchanges were made.Depends on #247