Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if Ubuntu has new runc #166

Closed

Conversation

edsantiago
Copy link
Member

This is an empty commit and empty PR. Purpose is to see if Ubuntu
has picked up a fixed runc, which would allow us to close

containers/podman#15025

Signed-off-by: Ed Santiago [email protected]

This is an empty commit and empty PR. Purpose is to see if Ubuntu
has picked up a fixed runc, which would allow us to close

   containers/podman#15025

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
Copy link
Member Author

Broken runc version is 1.1.0-0ubuntu1-amd64. If new build gets same version, close this PR.

@github-actions
Copy link

Cirrus CI build successful. Found built image names and IDs:

Name ID
build-push build-push-c4702687894700032
fedora fedora-c4702687894700032
fedora-aws ami-092c8a881bb22c616
fedora-netavark fedora-netavark-c4702687894700032
fedora-netavark-aws-arm64 ami-0a9166d666e76a91a
fedora-podman-aws-arm64 ami-0d7da5c5b1b4530b2
fedora-podman-py fedora-podman-py-c4702687894700032
prior-fedora prior-fedora-c4702687894700032
ubuntu ubuntu-c4702687894700032

@edsantiago
Copy link
Member Author

In this line in the ubuntu Cache Image job I see:

    ubuntu: Unpacking runc (1.1.0-0ubuntu1) ...

...which suggests that runc is still broken. But I'm not sure I got the right one (the Base one does not show runc anywhere in its logs). @cevich if you agree with my assessment, please just close this PR.

@cevich
Copy link
Member

cevich commented Aug 10, 2022

It's normal not to see this in the base image. For the future, a (potentially) faster way to learn this is:

Fire up the container-analog to the VM you're interested in. For example, quay.io/libpod/fedora_podman:c<IMG_SFX>, or prior-fedora_podman, or ubuntu_podman. You can just run apt-get update directly and see what happens.

Just be aware the container images are fairly large, like 600-800mb. If you're on a slower network, hack/get_ci_vm.sh is your friend. Along with the same 'apt-get update` of course.

I would just close this, but, do you have a sense of how much coverage we're loosing?

I fully anticipate it could be months (or never) that runc gets updated in Ubuntu. That's been the pattern in the past, and why we've needed Lokesh to custom build one 😞

@cevich
Copy link
Member

cevich commented Aug 10, 2022

"How-much" clarification: For example, is it just one or two tests that are otherwise executed elsewhere (like in Fedora) under crun?

@edsantiago
Copy link
Member Author

Seven tests are currently skipped on cgroupsv1:

030-run.bats-@test "podman run - uidmapping has no /sys/kernel mounts" {
030-run.bats-@test "podman run update /etc/hosts" {
170-run-userns.bats-@test "podman --group-add without keep-groups while in a userns" {
170-run-userns.bats-@test "rootful pod with custom ID mapping" {
400-unprivileged-access.bats-@test "podman container storage is not accessible by unprivileged users" {
500-networking.bats-@test "podman networking: port with --userns=keep-id for rootless or --uidmap=* for rootful" {
500-networking.bats-@test "podman run /etc/* permissions" {

Closing, since the issue is not resolved.

@edsantiago edsantiago closed this Aug 15, 2022
@edsantiago edsantiago deleted the see_if_ubuntu_has_new_runc branch August 15, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants