Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify arm64 in relevant tasks for clarity #145

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Specify arm64 in relevant tasks for clarity #145

merged 1 commit into from
Jul 1, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jul 1, 2022

piggybacks on #143

@cevich PTAL

@lsm5 lsm5 requested a review from cevich July 1, 2022 15:43
@lsm5 lsm5 force-pushed the specify-aarch64 branch 2 times, most recently from 35ea7d1 to 01a1f57 Compare July 1, 2022 15:48
@lsm5 lsm5 changed the title Specify aarch64 Specify arm64 in relevant tasks for clarity Jul 1, 2022
@cevich cevich added no_build-push Don't build the build-push image no_fedora Don't build any fedora images no_fedora_podman Don't build the fedora_podman image no_fedora-aws Don't build any fedora-aws images no_fedora-aws-arm64 Don't build any fedora-aws-arm64 images no_fedora-netavark Don't build the fedora-netavark image no_fedora-netavark-aws-arm64 Don't build the fedora-netavark-aws image no_fedora-podman-aws-arm64 Don't build the fedora-podman-aws image no_fedora-podman-py Don't build the fedora-podman-py image no_image-builder Don't build the image-builder image no_prior-fedora Don't build any prior-fedora images no_prior-fedora_podman Don't build the prior-fedora_podman image no_skopeo_cidev Don't build the skopeo_cidev image no_ubuntu labels Jul 1, 2022
@lsm5 lsm5 force-pushed the specify-aarch64 branch from 01a1f57 to 202e5a1 Compare July 1, 2022 16:00
@lsm5 lsm5 force-pushed the specify-aarch64 branch from 202e5a1 to 7077327 Compare July 1, 2022 16:06
cevich
cevich approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure you update the no_* labels before merging 😃

@lsm5
Copy link
Member Author

lsm5 commented Jul 1, 2022

LGTM. Make sure you update the no_* labels before merging smiley

yes, updated just now. PTAL

@cevich
Copy link
Member

cevich commented Jul 1, 2022

@lsm5 BTW if this works, please feel free to just merge it.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Cirrus CI build successful. Image ID c4543551957630976 ready for use.

@lsm5
Copy link
Member Author

lsm5 commented Jul 1, 2022

@cevich all green. Merging..

@lsm5 lsm5 merged commit 66fc344 into containers:main Jul 1, 2022
@lsm5
Copy link
Member Author

lsm5 commented Jul 1, 2022

@cevich ohh, I should have removed the labels before merging, right?

@cevich
Copy link
Member

cevich commented Jul 1, 2022

Nope (for the record) it's fine. Nothing significant VM image wise happens on merge, it's all in PRs. Only some container images are built on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cevich cevich cevich approved these changes

Assignees
No one assigned
Labels
no_build-push Don't build the build-push image no_fedora_podman Don't build the fedora_podman image no_fedora Don't build any fedora images no_fedora-aws Don't build any fedora-aws images no_fedora-aws-arm64 Don't build any fedora-aws-arm64 images no_fedora-netavark Don't build the fedora-netavark image no_fedora-netavark-aws-arm64 Don't build the fedora-netavark-aws image no_fedora-podman-aws-arm64 Don't build the fedora-podman-aws image no_fedora-podman-py Don't build the fedora-podman-py image no_image-builder Don't build the image-builder image no_prior-fedora_podman Don't build the prior-fedora_podman image no_prior-fedora Don't build any prior-fedora images no_skopeo_cidev Don't build the skopeo_cidev image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsm5 @cevich