-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete image-building automation docs #14
Conversation
5e4bc3a
to
1a10fb3
Compare
@edsantiago @lsm5 This one is a doozy, but will hopefully be enlightening and informative. PTAL when you have an afternoon or two, and run through the debugging section. I've been through this process with @baude but want to ensure the documentation matches and works for you. WARNING: Some parts are very network and CPU intensive, and require bare-metal (a VM won't work) 😖 Expected outcome: You understand the process (generally) and be able to update base-images, e.g. F32 -> F33 (when it comes out). Thanks in advance. |
(rebased / force-pushed) |
Rebased/force pushed w/ all recommended changes. |
@edsantiago ooof okay I'm done updating this for now. I don't think I can get the |
I'm totally OK with leaving the |
My thinking also, it's easy enough to just press cancel for now. |
Also mark image-building tasks as 'stateful'. Ref: https://cirrus-ci.org/guide/writing-tasks/#stateful-tasks This avoids task-cancellation (due to new code push) interrupting packer and possibly causing orphaned VMs, and disk images. Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I walked through the debugging section.
It told me disk images were created and also that artifacts were exported.
So, LGTM from me.
Fantastic @lsm5 thanks a bunch for going through that. It gives me confidence the documentation is on-target. |
@edsantiago okay if I merge this or would you like to take a manual run through the instructions? IMHO, it's not necessary as both Lokesh and Brent have been through them successfully. |
thanks @edsantiago and @lsm5 and @baude |
This fills out the automation-portion of the processes. I intend to followup in another PR, with details on manually performing these tasks. i.e. using the
Makefile
locally.Signed-off-by: Chris Evich [email protected]