Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete image-building automation docs #14

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 28, 2020

This fills out the automation-portion of the processes. I intend to followup in another PR, with details on manually performing these tasks. i.e. using the Makefile locally.

Signed-off-by: Chris Evich [email protected]

@cevich cevich force-pushed the more_docs branch 3 times, most recently from 5e4bc3a to 1a10fb3 Compare August 31, 2020 14:28
@cevich cevich requested review from edsantiago, baude and lsm5 and removed request for baude August 31, 2020 14:28
@cevich
Copy link
Member Author

cevich commented Aug 31, 2020

@edsantiago @lsm5 This one is a doozy, but will hopefully be enlightening and informative. PTAL when you have an afternoon or two, and run through the debugging section. I've been through this process with @baude but want to ensure the documentation matches and works for you. WARNING: Some parts are very network and CPU intensive, and require bare-metal (a VM won't work) 😖

Expected outcome: You understand the process (generally) and be able to update base-images, e.g. F32 -> F33 (when it comes out).

Thanks in advance.

@cevich
Copy link
Member Author

cevich commented Sep 8, 2020

(rebased / force-pushed)

.cirrus.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@cevich
Copy link
Member Author

cevich commented Sep 16, 2020

Rebased/force pushed w/ all recommended changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
@cevich
Copy link
Member Author

cevich commented Sep 16, 2020

@edsantiago ooof okay I'm done updating this for now. I don't think I can get the skip thing working properly. May have to forget that feature for now or fall back to interpreting magic strings in the title (not my fav.).

@edsantiago
Copy link
Member

I'm totally OK with leaving the skip as future work.

@cevich
Copy link
Member Author

cevich commented Sep 17, 2020

I'm totally OK with leaving the skip as future work.

My thinking also, it's easy enough to just press cancel for now.

Also mark image-building tasks as 'stateful'.  Ref:
https://cirrus-ci.org/guide/writing-tasks/#stateful-tasks

This avoids task-cancellation (due to new code push) interrupting
packer and possibly causing orphaned VMs, and disk images.

Signed-off-by: Chris Evich <[email protected]>
README.md Show resolved Hide resolved
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I walked through the debugging section.

It told me disk images were created and also that artifacts were exported.

So, LGTM from me.

@cevich
Copy link
Member Author

cevich commented Sep 17, 2020

Fantastic @lsm5 thanks a bunch for going through that. It gives me confidence the documentation is on-target.

@cevich cevich marked this pull request as ready for review September 17, 2020 17:20
@cevich
Copy link
Member Author

cevich commented Sep 17, 2020

@edsantiago okay if I merge this or would you like to take a manual run through the instructions? IMHO, it's not necessary as both Lokesh and Brent have been through them successfully.

@edsantiago
Copy link
Member

@lsm5's and @baude's experience is good enough for me!

@cevich cevich merged commit 46a8ccd into containers:master Sep 17, 2020
@cevich
Copy link
Member Author

cevich commented Sep 17, 2020

thanks @edsantiago and @lsm5 and @baude

@cevich cevich deleted the more_docs branch July 19, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants