Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use podman/*_release contents in packer #135

Closed
cevich opened this issue May 26, 2022 · 0 comments · Fixed by #178
Closed

Re-use podman/*_release contents in packer #135

cevich opened this issue May 26, 2022 · 0 comments · Fixed by #178
Assignees

Comments

@cevich
Copy link
Member

cevich commented May 26, 2022

There's no practical reason why this can't be achieved. It would reduce the mental-drain when updating from one release to another - as in, you'd only need to update the version in one place instead of three. Probably the safest/easiest way is to consume the contents in the Makefile, and pass them as vars into packer.

@cevich cevich self-assigned this Aug 22, 2022
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 23, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 24, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 24, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 24, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 24, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 24, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 25, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding the
release-version in base-image YAML and retrieving it as needed.  This
also has the added side-benefit of allowing the release version to be
tagged on the images themselves for reference.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 25, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding release-versions
and other key details into a simple YAML file.  Craft a helper script
for the `Makefile` to use in retrieving values as required.  Having
a single source of truth for these details makes it easy for multiple
tools to access and maintainers to fiddle with with as needed.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 25, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding release-versions
and other key details into a simple YAML file.  Craft a helper script
for the `Makefile` to use in retrieving values as required.  Having
a single source of truth for these details makes it easy for multiple
tools to access and maintainers to fiddle with with as needed.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 25, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding release-versions
and other key details into a simple YAML file.  Craft a helper script
for the `Makefile` to use in retrieving values as required.  Having
a single source of truth for these details makes it easy for multiple
tools to access and maintainers to fiddle with with as needed.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 25, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding release-versions
and other key details into a simple YAML file.  Craft a helper script
for the `Makefile` to use in retrieving values as required.  Having
a single source of truth for these details makes it easy for multiple
tools to access and maintainers to fiddle with with as needed.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 25, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding release-versions
and other key details into a simple YAML file.  Craft a helper script
for the `Makefile` to use in retrieving values as required.  Having
a single source of truth for these details makes it easy for multiple
tools to access and maintainers to fiddle with with as needed.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 25, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding release-versions
and other key details into a simple YAML file.  Craft a helper script
for the `Makefile` to use in retrieving values as required.  Having
a single source of truth for these details makes it easy for multiple
tools to access and maintainers to fiddle with with as needed.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 25, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding release-versions
and other key details into a simple YAML file.  Craft a helper script
for the `Makefile` to use in retrieving values as required.  Having
a single source of truth for these details makes it easy for multiple
tools to access and maintainers to fiddle with with as needed.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 26, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Reduce this burden by encoding release-versions
and other key details into a simple YAML file.  Craft a helper script
for the `Makefile` to use in retrieving values as required.  Having
a single source of truth for these details makes it easy for multiple
tools to access and maintainers to fiddle with with as needed.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 29, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Since all images are produced from make targets,
simple variables can serve as a single-source-of-truth.  Update the
`Makefile` and image build configurations to accept these values at
build time.

Also do some minor re-arranging, code cleanup, and comment updates.

Signed-off-by: Chris Evich <[email protected]>
cevich added a commit to cevich/automation_images that referenced this issue Aug 30, 2022
Fixes: containers#135

Previously, a maintainer integrating a new OS release was required to
update multiple files.  Since all images are produced from make targets,
simple variables can serve as a single-source-of-truth.  Update the
`Makefile` and image build configurations to accept these values at
build time.

Also do some minor re-arranging, code cleanup, and comment updates.

Signed-off-by: Chris Evich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant