Fix 'Expecting pub_dns to be set/non-empty' error #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's 258b2c212ddd66fd7b267a3bf6d03139f4ed3d50. |
While processing instances, if the script encounters an instance running past PW_MAX_HOURS, it will force-terminate it. However, this check was happening before the script had looked up the required 'pub_dns' value. Fix this by relocating the check. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
mac_pw_pool_fix_pub_dns
branch
from
258b2c2 to
436dceb
Compare
|
Tested changes by temporarily replacing script on maintenance VM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While processing instances, if the script encounters an instance running past PW_MAX_HOURS, it will force-terminate it. However, this check was happening before the script had looked up the required 'pub_dns' value. Fix this by relocating the check.