-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update python base images #98
Conversation
audio-to-text/client/Containerfile
Outdated
@@ -1,8 +1,8 @@ | |||
FROM registry.access.redhat.com/ubi9/python-39:latest | |||
FROM registry.access.redhat.com/ubi9/python-311:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to pin the version? Using the latest tag might cause some issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment is applied to everywhere the latest tag is being used. Renovate can be onboarded and used for bumping the versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated to pin all python versions
Would it make sense to pin the version of Did we confirm all of the model servers and AI apps work with python 3.11? |
Needs a rebase. |
I'm going to pin both llamacpp-python and the python image to match what Liora has in her tests, sg? |
Fine with me. |
55e0f73
to
36314de
Compare
Signed-off-by: sallyom <[email protected]>
36314de
to
18d0540
Compare
Signed-off-by: sallyom <[email protected]>
Signed-off-by: sallyom <[email protected]>
Signed-off-by: sallyom <[email protected]>
2866eec
to
820d4fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
version of cmake in python39 is 3.20, but llama-cpp-python requires >3.21
updating the base python image everywhere to keep consistency
/cc @MichaelClifford
/cc @lmilbaum
/cc @jeffmaury