Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python base images #98

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Mar 26, 2024

version of cmake in python39 is 3.20, but llama-cpp-python requires >3.21
updating the base python image everywhere to keep consistency

/cc @MichaelClifford
/cc @lmilbaum
/cc @jeffmaury

@lmilbaum lmilbaum self-requested a review March 26, 2024 16:59
@@ -1,8 +1,8 @@
FROM registry.access.redhat.com/ubi9/python-39:latest
FROM registry.access.redhat.com/ubi9/python-311:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to pin the version? Using the latest tag might cause some issues

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment is applied to everywhere the latest tag is being used. Renovate can be onboarded and used for bumping the versions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to pin all python versions

@MichaelClifford
Copy link
Collaborator

Would it make sense to pin the version of llama_cpp_python that worked earlier instead changing the base image? Seems like updating the base image might have wide reaching affect throughout the project.

Did we confirm all of the model servers and AI apps work with python 3.11?

@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2024

Needs a rebase.

@sallyom
Copy link
Collaborator Author

sallyom commented Mar 28, 2024

I'm going to pin both llamacpp-python and the python image to match what Liora has in her tests, sg?

@rhatdan
Copy link
Member

rhatdan commented Mar 28, 2024

Fine with me.

@sallyom sallyom force-pushed the update-python-base branch 2 times, most recently from 55e0f73 to 36314de Compare March 28, 2024 18:59
@sallyom sallyom force-pushed the update-python-base branch from 36314de to 18d0540 Compare March 28, 2024 19:01
sallyom added 3 commits March 28, 2024 15:15
Signed-off-by: sallyom <[email protected]>
Signed-off-by: sallyom <[email protected]>
Signed-off-by: sallyom <[email protected]>
@sallyom sallyom force-pushed the update-python-base branch from 2866eec to 820d4fd Compare March 28, 2024 20:03
Copy link
Collaborator

@lmilbaum lmilbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmilbaum lmilbaum merged commit 10c6df3 into containers:main Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants