Bootc - Add git and git-lfs packages #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiendupont
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
rhatdan
reviewed
Sep 12, 2024
training/amd-bootc/cmd
Outdated
| @@ -0,0 +1 @@ | |||
| make amd FROM=registry.redhat.io/rhel9/rhel-bootc:9.4 DRIVER_TOOLKIT_IMAGE=registry.redhat.io/rhel9/driver-toolkit:5.14.0-427.31.1.el9_4 | |||
There was a problem hiding this comment.
I thought we were trying to avoid hard coding a rhel image into this, so that this upstream project can be used by anyone?
There was a problem hiding this comment.
That's a leftover from tests. I removed it.
When working with AI/ML recipes, it is frequent to pull versioned software and data from Git repositories. This change adds the `git` and `git-lfs` packages. Signed-off-by: Fabien Dupont <[email protected]>
fabiendupont
force-pushed
the
bootc-add-git-package
branch
from
cf52774 to
3c6b84b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with AI/ML recipes, it is frequent to pull versioned software and data from Git repositories. This change adds the
gitandgit-lfspackages.