Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move --target-arch to image builder args #755

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

javipolo
Copy link
Collaborator

@javipolo javipolo commented Aug 12, 2024

Move --target-arch to be an argument to bootc-image-builder instead of as an argument to podman

@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2024

Looks like you have an ancient version of bootc-image-builder?

podman run quay.io/centos-bootc/bootc-image-builder:latest --help | grep arch
--target-arch string build for the given target architecture (experimental)

@javipolo javipolo force-pushed the image_builder_remove_arch branch from 441261c to d2b6e80 Compare August 12, 2024 20:24
@javipolo
Copy link
Collaborator Author

Looks like you have an ancient version of bootc-image-builder?

podman run quay.io/centos-bootc/bootc-image-builder:latest --help | grep arch --target-arch string build for the given target architecture (experimental)

I just saw the problem now 🤦
we were passing --target-arch as an argument to podman instead of passing it as an argument to the bootc-image-builder container 🤦 🤦

I'm going to change the PR description to reflect that :)

@javipolo javipolo changed the title Remove --target-arch from image builder args Move --target-arch to image builder args Aug 12, 2024
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 346e1a1 into containers:main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants