ilab wrapper: exec for better signal handling / termination
#697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omertuc
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
If the wrapper script is killed, the container will be left running. Instead of just running the command, use `exec` to replace the wrapper script with the command, so that the command will receive the same signals as the wrapper script and the container will be terminated as expected. Signed-off-by: Omer Tuchfeld <[email protected]>
|
I just checked and it works as expected. With this change the systemd service behaves properly. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the wrapper script is killed, the container will be left running. Instead of just running the command, use
execto replace the wrapper script with the command, so that the command will receive the same signals as the wrapper script and the container will be terminated as expected.