Set group permissions on whispercpp app folder #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmcollier
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
Signed-off-by: John Collier <[email protected]>
johnmcollier
force-pushed
the
whispercppgid
branch
from
1eb78ba to
d029eba
Compare
rhatdan
reviewed
Jul 18, 2024
Signed-off-by: John Collier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the whispercpp dockerfile to mark the
/appfolder as owned by the GID 0, which is the group OpenShift uses.For some context, our team has been looking at consuming some of the Podman Desktop AI lab recipes via RHDH software templates, which will include OpenShift as a deployment target for the recipes. While trying to run the whispercpp model server, we found it was running into permissions issues when using the UID that OpenShift assigns to it (on the default,
restrictedSCC). Setting the user ID to1001and the group owner on the folder to0resolved these issues.We've verified both locally and on OpenShift, let me know if this change is okay to go in. We also have an image built from this branch up at quay.io/redhat-ai-dev/whispercpp:latest