Changing os-release file parameter from BUILD_ID to RHEL_AI_VERSION #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsorya
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
tsorya
force-pushed
the
igal/rhel_ai_version
branch
3 times, most recently
from
43a7b45 to
93a0fec
Compare
…D as it matches much better. Changing the way we set image_version_id label, in order for it to work in konflux we should use LABEL in container file Signed-off-by: Igal Tsoiref <[email protected]>
tsorya
force-pushed
the
igal/rhel_ai_version
branch
from
93a0fec to
9d175ab
Compare
lmilbaum
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing os-release file parameter from BUILD_ID to RHEL_AI_VERSION_ID as it matches much better.
Changing the way we set image_version label, in order for it to work in konflux we should use LABEL in container file