Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing nvidia container file #673

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Fixing nvidia container file #673

merged 1 commit into from
Jul 14, 2024

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Jul 14, 2024

No description provided.

@tsorya
Fixing nvidia container file
b497531 
Signed-off-by: Igal Tsoiref <[email protected]>
@tsorya tsorya force-pushed the igal/rhel_ai_version branch from d1e5e6e to b497531 Compare July 14, 2024 12:17
@lmilbaum
Copy link
Collaborator

Would you mind checking why CI was not triggered on this PR and fix that on the way?

@tsorya
Copy link
Contributor Author

tsorya commented Jul 14, 2024

Would you mind checking why CI was not triggered on this PR and fix that on the way?

Looking

@tsorya
Copy link
Contributor Author

tsorya commented Jul 14, 2024

opened #674 to test ci issue, i think i found why it doesn't start but there is a problem with aws creds too

@lmilbaum
Copy link
Collaborator

opened #674 to test ci issue, i think i found why it doesn't start but there is a problem with aws creds too

As discussed over Slack, lets differ the CI issue to a later stage. Please confirm the change has passed local tests and lets approve and merge this one. Please follow up with the push or/and scheduled workflows that they are still green.

@tsorya
Copy link
Contributor Author

tsorya commented Jul 14, 2024

Tested locally, looks good

@lmilbaum lmilbaum merged commit aa7d470 into containers:main Jul 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmilbaum lmilbaum lmilbaum approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sallyom sallyom Awaiting requested review from sallyom sallyom is a code owner

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

@Gregory-Pereira Gregory-Pereira Awaiting requested review from Gregory-Pereira Gregory-Pereira is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsorya @lmilbaum