Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Makefiles #534

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Improve Makefiles #534

merged 3 commits into from
Jun 9, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jun 6, 2024

No description provided.

rhatdan added 3 commits June 6, 2024 15:17
Signed-off-by: Dan Walsh <[email protected]>
Signed-off-by: Dan Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Jun 6, 2024

@cgwalters PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Jun 6, 2024

Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, let me know what of these training images we want to see worked into CI

@rhatdan rhatdan merged commit 45cebdb into containers:main Jun 9, 2024
1 check passed
@rhatdan
Copy link
Member Author

rhatdan commented Jun 9, 2024

The training objects take a long time to process and move a ton of data around. So you could try with deepspeed and vllm to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants