Add building of instructlab container images #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
requested review from
MichaelClifford,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
This is working (building) for me. FWIW, Seems to be needed. There needs to be a way to build all of this together with the images in the amd/nvidia/intel bootable container images. |
Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
changed the title
|
Ok removed [WIP] Just need to figure out how to push them to ai-lab. |
|
Built nvidia image as: https://quay.io/repository/swalter/instructlab-nvidia |
3 tasks
|
We could use these e2e tests to ensure that these work: instructlab/instructlab#1016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not sure we need this, but it is worth playing with.