set summarizer write to tempfile #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
requested review from
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
Similar issue encountered in: #307 but this solves it a better way |
|
There is security risks in writing to tmp, can you use a tmpfile name rather then a hard coded file name? |
Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
changed the title
|
Thanks @rhatdan Changed it to use a tempfile instead. |
rhatdan
reviewed
Apr 24, 2024
| @@ -49,12 +50,12 @@ def read_file(file): | |||
| file_type = file.type | |||
|
|
|||
| if file_type == "application/pdf": | |||
| with open(file.name, "wb") as f: | |||
| temp = tempfile.NamedTemporaryFile() | |||
There was a problem hiding this comment.
You still need to remove this when you are done with it?
There was a problem hiding this comment.
When I tested it the tempfile deleted after the file was no longer being used.
There was a problem hiding this comment.
Use the [tempfile module](http://docs.python.org/2/library/tempfile.html); it creates temporary files that auto-delete.
From the [tempfile.NamedTemporaryFile() documentation](http://docs.python.org/2/library/tempfile.html#tempfile.NamedTemporaryFile):
If delete is true (the default), the file is deleted as soon as it is closed.
Cool
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #302
Noticed summarizer was having write issues in container. Using the
/tmp/directory should address it.