aardvark-dns: add support for container's custom dns_servers
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flouthoc
added a commit
to flouthoc/netavark
that referenced
this pull request
Oct 17, 2022
…ners Netavark now accepts `dns_servers` as part of `NetworkOptions` which contains list of comma seperated custom DNS servers for containers. Aardvark-dns will use these as resolver for a specific container instead of host's default resolver. Implements feature here: containers/aardvark-dns#240 Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Oct 17, 2022
Netavark now accets `dns_servers` for each container which allows containers to use custom DNS servers as resolvers instead of falling back to host's resolver. Following field allows callers to libnetwork to pass newly added field to `netavark` and `aarvark-dns` Actual feature implemented * containers/aardvark-dns#240 * containers/netavark#452 [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
container_custom_dns_server
branch
from
2cfd736 to
89571c7
Compare
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Oct 17, 2022
Netavark now accets `dns_servers` for each container which allows containers to use custom DNS servers as resolvers instead of falling back to host's resolver. Following field allows callers to libnetwork to pass newly added field to `netavark` and `aarvark-dns` Actual feature implemented * containers/aardvark-dns#240 * containers/netavark#452 [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Oct 17, 2022
Aardvark-dns and netavark now accepts custom DNS servers for containers via new config field `dns_servers`. New field allows containers to use custom resolvers instead of host's default resolvers. Following commit instruments libpod to pass these custom DNS servers set via `--dns` or central config to the network stack. Depends-on: * Common: containers/common#1189 * Netavark: containers/netavark#452 * Aardvark-dns: containers/aardvark-dns#240 [NO NEW TESTS ADDED] [NO TESTS ADDED] Signed-off-by: Aditya R <[email protected]>
|
Looks like I'm facing chicken-egg problem with integration tests, |
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Oct 17, 2022
Netavark now accets `dns_servers` for each container which allows containers to use custom DNS servers as resolvers instead of falling back to host's resolver. Following field allows callers to libnetwork to pass newly added field to `netavark` and `aarvark-dns` Actual feature implemented * containers/aardvark-dns#240 * containers/netavark#452 [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/netavark
that referenced
this pull request
Oct 17, 2022
…ners Netavark now accepts `dns_servers` as part of `NetworkOptions` which contains list of comma seperated custom DNS servers for containers. Aardvark-dns will use these as resolver for a specific container instead of host's default resolver. Implements feature here: containers/aardvark-dns#240 Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/netavark
that referenced
this pull request
Oct 17, 2022
…ners Netavark now accepts `dns_servers` as part of `NetworkOptions` which contains list of comma seperated custom DNS servers for containers. Aardvark-dns will use these as resolver for a specific container instead of host's default resolver. Implements feature here: containers/aardvark-dns#240 Signed-off-by: Aditya R <[email protected]>
|
We've done this at least once before. How did we handle it then? |
@mheon That was only aardvark-change and netavark was blocked on it but no issue at all here as well, this is sorted here containers/netavark#452 (comment) , we will get netavark PR in first then we can merge this and after that i'll unskip the netavark test in a followup PR. |
flouthoc
added a commit
to flouthoc/netavark
that referenced
this pull request
Oct 17, 2022
…ners Netavark now accepts `dns_servers` as part of `NetworkOptions` which contains list of comma seperated custom DNS servers for containers. Aardvark-dns will use these as resolver for a specific container instead of host's default resolver. Implements feature here: containers/aardvark-dns#240 Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/netavark
that referenced
this pull request
Oct 17, 2022
…ners Netavark now accepts `dns_servers` as part of `NetworkOptions` which contains list of comma seperated custom DNS servers for containers. Aardvark-dns will use these as resolver for a specific container instead of host's default resolver. Implements feature here: containers/aardvark-dns#240 Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/netavark
that referenced
this pull request
Oct 17, 2022
…ners Netavark now accepts `dns_servers` as part of `NetworkOptions` which contains list of comma seperated custom DNS servers for containers. Aardvark-dns will use these as resolver for a specific container instead of host's default resolver. Implements feature here: containers/aardvark-dns#240 Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
container_custom_dns_server
branch
from
89571c7 to
c35cffb
Compare
Luap99
reviewed
Oct 19, 2022
flouthoc
force-pushed
the
container_custom_dns_server
branch
from
641a5b1 to
1c6d50a
Compare
flouthoc
force-pushed
the
container_custom_dns_server
branch
from
1c6d50a to
f6df229
Compare
Luap99
reviewed
Oct 20, 2022
|
Code LGTM minus comments from @Luap99 |
flouthoc
force-pushed
the
container_custom_dns_server
branch
from
f6df229 to
355293d
Compare
Aardvark-dns's config now allows containers to define a list of one of more custom DNS servers. If custom DNS servers are specified for a container aardvark-dns will use these custom DNS servers are resolvers instead of host's default resolvers. Signed-off-by: Aditya R <[email protected]>
Signed-off-by: Aditya R <[email protected]>
Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
container_custom_dns_server
branch
from
355293d to
d3cc7e0
Compare
|
/lgtm |
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Jan 22, 2023
Aardvark-dns and netavark now accepts custom DNS servers for containers via new config field `dns_servers`. New field allows containers to use custom resolvers instead of host's default resolvers. Following commit instruments libpod to pass these custom DNS servers set via `--dns` or central config to the network stack. Depends-on: * Common: containers/common#1189 * Netavark: containers/netavark#452 * Aardvark-dns: containers/aardvark-dns#240 Signed-off-by: Aditya R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aardvark-dns's config now allows containers to define a list of one of more custom
DNSservers. If customDNSservers are specified for a container aardvark-dns will use these custom DNS servers are resolver instead of host's default revolvers.How to verify
integrationandunittests.podman run -it --rm --network test --dns 8.8.8.8 ctr dig google.comto use8.8.8.8as a resolver instead of host's configured resolver.