Reworked module fetching to clone specific branch with depth 1 (#115)

Reworked module fetching to clone specific branch with depth 1

cct/lib/git.py

@@ -1,5 +1,6 @@
 import logging
 import os
+import shutil
 import subprocess
 
 from cct.errors import CCTError
@@ -8,19 +9,25 @@
 
 
 def clone_repo(url, path, version=None, force=False):
+    # this is not a nice way, but we are passing version as a None explictly on multiple places
+    if not version:
+        version = "master"
     try:
-        if not os.path.exists(path):
-            logger.info("Cloning %s into %s" % (url, path))
-            subprocess.check_call(["git", "clone", url, path])
-            if version:
-                logger.info('Checking out %s revision' % version)
-                subprocess.check_call(['git', 'checkout', version], cwd=path)
-        elif os.path.exists(path) and force:
-            logger.info('Forcing %s revision for %s' % (version, path))
-            subprocess.check_call(['git', 'checkout', version], cwd=path)
+        if os.path.exists(path):
+            if force:
+                logger.info("Removing old module from path: '%'." % path)
+                shutil.rmtree(path)
+            else:
+                return
+
+        logger.info("Cloning %s into %s" % (url, path))
+        cmd = ["git", "clone", "--depth", "1", url, path, "-b", version]
+        logger.debug("Running '%s'" % ' '.join(cmd))
+        out = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
 
     except Exception as ex:
         logger.error("Cannot clone repo %s into %s: %s", url, path, ex)
+        raise
         raise CCTError('Cannot clone repo %s, %s' % (url, ex))
 
 

cct/module.py

@@ -67,7 +67,6 @@ def install_module(self, url, version, override=False):
         repo_dir = "%s/%s" % (self.directory, os.path.basename(url))
         if repo_dir.endswith('git'):
             repo_dir = repo_dir[:-4]
-        logger.info("Cloning module into %s" % repo_dir)
         clone_repo(url, repo_dir, self.version, self.override)
         self.discover_modules(repo_dir)