Ignore NetNS path errors on delete #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: silenceper <[email protected]>
|
/PTAL @dcbw |
|
Great! Thanks |
6 tasks
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 28, 2022
If the network namespace has been deleted before CNI DEL is invoked, Cilium CNI should still invoke the delegated IPAM plugin to release the IP address. This matches the behavior of the "bridge" reference plugin, which invokes delegated plugin DEL when the network namespace has been deleted: containernetworking/plugins#685 containernetworking/plugins#686 I tested the changes in a kind cluster configuring Cilium CNI to use the reference host-local plugin for IPAM. The cilium connectivity tests pass. I also repeatedly deleted pods from a deployment to trigger the "Unable to enter namespace" warning in the Cilium CNI logs, then verified that the delegated IPAM plugin DEL was invoked to release the IPs. Signed-off-by: Will Daly <[email protected]>
dezmodue
pushed a commit
to dezmodue/cilium
that referenced
this pull request
Aug 10, 2022
If the network namespace has been deleted before CNI DEL is invoked, Cilium CNI should still invoke the delegated IPAM plugin to release the IP address. This matches the behavior of the "bridge" reference plugin, which invokes delegated plugin DEL when the network namespace has been deleted: containernetworking/plugins#685 containernetworking/plugins#686 I tested the changes in a kind cluster configuring Cilium CNI to use the reference host-local plugin for IPAM. The cilium connectivity tests pass. I also repeatedly deleted pods from a deployment to trigger the "Unable to enter namespace" warning in the Cilium CNI logs, then verified that the delegated IPAM plugin DEL was invoked to release the IPs. Signed-off-by: Will Daly <[email protected]>
nbusseneau
pushed a commit
to nbusseneau/cilium
that referenced
this pull request
Aug 10, 2022
[ upstream commit 645c8d5 ] If the network namespace has been deleted before CNI DEL is invoked, Cilium CNI should still invoke the delegated IPAM plugin to release the IP address. This matches the behavior of the "bridge" reference plugin, which invokes delegated plugin DEL when the network namespace has been deleted: containernetworking/plugins#685 containernetworking/plugins#686 I tested the changes in a kind cluster configuring Cilium CNI to use the reference host-local plugin for IPAM. The cilium connectivity tests pass. I also repeatedly deleted pods from a deployment to trigger the "Unable to enter namespace" warning in the Cilium CNI logs, then verified that the delegated IPAM plugin DEL was invoked to release the IPs. Signed-off-by: Will Daly <[email protected]> Signed-off-by: Nicolas Busseneau <[email protected]>
tklauser
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 11, 2022
[ upstream commit 645c8d5 ] If the network namespace has been deleted before CNI DEL is invoked, Cilium CNI should still invoke the delegated IPAM plugin to release the IP address. This matches the behavior of the "bridge" reference plugin, which invokes delegated plugin DEL when the network namespace has been deleted: containernetworking/plugins#685 containernetworking/plugins#686 I tested the changes in a kind cluster configuring Cilium CNI to use the reference host-local plugin for IPAM. The cilium connectivity tests pass. I also repeatedly deleted pods from a deployment to trigger the "Unable to enter namespace" warning in the Cilium CNI logs, then verified that the delegated IPAM plugin DEL was invoked to release the IPs. Signed-off-by: Will Daly <[email protected]> Signed-off-by: Nicolas Busseneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #685