Allow multiple routes to be added for the same prefix #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formally #602 which entered rebase/revendor hell |
|
I think this is right... the only difference between RouteAdd and RouteAddECMP is that RouteAdd() uses the unix.NLM_F_EXCL flag to hard fail if mostly-the-same route is added a second time. So /lgtm but I have a question or two about the bridge change. |
dcbw
reviewed
Apr 19, 2021
plugins/main/bridge/bridge.go
Outdated
| @@ -122,7 +122,7 @@ func calcGateways(result *current.Result, n *NetConf) (*gwInfo, *gwInfo, error) | |||
|
|
|||
| // Add a default route for this family using the current | |||
| // gateway address if necessary. | |||
| if n.IsDefaultGW && !gws.defaultRouteFound { | |||
| if n.IsDefaultGW { | |||
There was a problem hiding this comment.
@mccv1r0 is this to allow multiple default routes for the bridge or something?
There was a problem hiding this comment.
Yes, but keeping it seems to behave too, so I added && !gws.defaultRouteFound back.
|
/lgtm |
Signed-off-by: Michael Cambria <[email protected]>
Enables ECMP Signed-off-by: Michael Cambria <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Nov 5, 2021
The default route will be added for each connected network, so when you would try to use two networks it would fail because the default route was already added. While we could ignore eexist error this is not what we want. If we only have one route and disconnect the network with the default route we will loose internet connectivity. To best way is to have each network create the default route. This can be done by not setting the NLM_F_EXCL flag for the netlink request. Also see this CNI bridge plugin PR which does the same there: containernetworking/plugins#615 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Nov 5, 2021
The default route will be added for each connected network, so when you would try to use two networks it would fail because the default route was already added. While we could ignore eexist error this is not what we want. If we only have one route and disconnect the network with the default route we will loose internet connectivity. To best way is to have each network create the default route. This can be done by not setting the NLM_F_EXCL flag for the netlink request. Also see this CNI bridge plugin PR which does the same there: containernetworking/plugins#615 Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple routes to be added for the same prefix.
Enables ECMP
Fixes: #601