Documentation: Add conventions doc #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@containernetworking/cni-maintainers I've updated based on our discussions on Wednesday. PTAL. |
rosenhouse
reviewed
Jan 20, 2017
| | Area | Purpose| Spec and Example | Runtime implementations | Plugin Implementations | | ||
| | ------ | ------ | ------ | ------ | ------ | ------ | | ||
| | labels | Pass`key=value` labels to plugins | <pre>"labels" : [<br /> { "key" : "app", "value" : "myapp" },<br /> { "key" : "env", "value" : "prod" }<br />] </pre> | none | none | | ||
| | port mappings | Pass mapping from ports on the host to ports in the container network namespace. | <pre>"port_mappings" : [<br /> { "host_port": 8080, "container_port": 80, "protocol": "tcp" },<br /> { "host_port": 8000, "container_port": 8001, "protocol": "udp" }<br />] </pre> | none | none | |
There was a problem hiding this comment.
"port mappings" is also listed above as a "plugin specific" field. If I recall correctly, the consensus from our meeting this week was that we preferred it live there, and not here. Maybe remove this row from this table?
There was a problem hiding this comment.
I though I'd already removed it from this table, oops. I just pushed a change to remove it.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.