Make the order of directory entries deterministic #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
*node.Readdir
returns directory entries in undeterministic orderon each call. Though the order of directory entries is up to the filesystem
implementation, undeterministic order on each call results in that the
filesystem clients see random file name on each call of
getdents
even to thesame seek position in that directory. This commit fixes this issue by sorting
the directory entries by the name.
repro:
On the host (expected):
In the container (unexpected):