Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod, Dockerfile: bump up dependencies #1832

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Conversation

ktock
Copy link
Member

@ktock ktock commented Oct 15, 2024

@AkihiroSuda
Copy link
Member

Can you update this with the latest containerd RC?

@AkihiroSuda
Copy link
Member

CI is failing

79.87 core/sandbox/proxy/controller.go:84:40: undefined: errdefs.FromGRPC
79.87 core/sandbox/proxy/controller.go:106:18: undefined: errdefs.FromGRPC
79.87 core/sandbox/proxy/controller.go:115:18: undefined: errdefs.FromGRPC
79.87 core/sandbox/proxy/controller.go:132:23: undefined: errdefs.FromGRPC
79.87 core/sandbox/proxy/controller.go:158:46: undefined: errdefs.FromGRPC
79.87 core/sandbox/proxy/controller.go:176:23: undefined: errdefs.FromGRPC
79.87 core/sandbox/proxy/controller.go:193:18: undefined: errdefs.FromGRPC
79.87 core/sandbox/proxy/store.go:44:32: undefined: errdefs.FromGRPC
79.87 core/sandbox/proxy/store.go:44:32: too many errors
89.25 make: *** [Makefile:258: bin/ctr] Error 1

Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
@ktock ktock changed the title go.mod: bump up dependencies go.mod, Dockerfile: bump up dependencies Nov 13, 2024
@ktock ktock force-pushed the gomodbump branch 4 times, most recently from fd95e7a to f022b73 Compare November 13, 2024 09:44
Signed-off-by: Kohei Tokunaga <[email protected]>
@ktock ktock marked this pull request as draft November 13, 2024 10:14
Signed-off-by: Kohei Tokunaga <[email protected]>
@ktock
Copy link
Member Author

ktock commented Nov 13, 2024

nerdctl v2 now adds port number to the registry host name in config.json, even when user doesn't specify it for nerdctl login. (https://github.com/containerd/nerdctl/blob/ef588dafa080e3dbc9c061ff3802affb66aef291/pkg/imgutil/dockerconfigresolver/registryurl.go#L53).

And that config.json doesn't seem to work for stargz-snapshotter (and also go-containerregistry (crane)).

For now, let's prioritize cutting a new relese of stargz-snapsshotter because stargz-snapshotter works fine with containerd v2.
I'll look deeper about it later.

@ktock ktock marked this pull request as ready for review November 13, 2024 14:32
This was referenced Nov 13, 2024
@ktock ktock requested a review from AkihiroSuda November 13, 2024 15:13
@AkihiroSuda AkihiroSuda merged commit fe111ee into containerd:main Nov 13, 2024
26 checks passed
@ktock ktock deleted the gomodbump branch November 13, 2024 17:48
@dmcgowan
Copy link
Member

Did one of the deps force the go version in the go.mod to 1.23?

@ktock
Copy link
Member Author

ktock commented Nov 13, 2024

Thanks for the comment. Fixing in #1863 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants