fix: rollback snapshot to prevent bolt deadlock

Signed-off-by: Chris Goller <[email protected]>
containerd · Jul 27, 2023 · 3486b7f · 3486b7f
1 parent 9e9e7a5
commit 3486b7f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/snapshot/snapshot.go b/snapshot/snapshot.go
@@ -316,8 +316,9 @@ func (o *snapshotter) commit(ctx context.Context, isRemote bool, name, key strin
 		return err
 	}
 
+	rollback := true
 	defer func() {
-		if err != nil {
+		if rollback {
 			if rerr := t.Rollback(); rerr != nil {
 				log.G(ctx).WithError(rerr).Warn("failed to rollback transaction")
 			}
@@ -342,6 +343,7 @@ func (o *snapshotter) commit(ctx context.Context, isRemote bool, name, key strin
 		return fmt.Errorf("failed to commit snapshot: %w", err)
 	}
 
+	rollback = false
 	return t.Commit()
 }